linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pm-graph: ignore sleepgraph.py artifacts
@ 2024-08-25  9:53 Yo-Jung (Leo) Lin
  2024-08-26 20:30 ` Todd Brandt
  2024-08-26 20:49 ` Todd Brandt
  0 siblings, 2 replies; 4+ messages in thread
From: Yo-Jung (Leo) Lin @ 2024-08-25  9:53 UTC (permalink / raw)
  Cc: linux-kernel-mentees, ricardo, skhan, 0xff07, Todd E Brandt,
	linux-kernel, linux-pm

By default, sleepgraph.py creates suspend-{date}-{time} directories
to store artifacts, or suspend-{date}-{time}-xN if the --multi option
is used. Ignore those directories by adding a .gitignore file.

Signed-off-by: Yo-Jung (Leo) Lin <0xff07@gmail.com>
---
 tools/power/pm-graph/.gitignore | 3 +++
 1 file changed, 3 insertions(+)
 create mode 100644 tools/power/pm-graph/.gitignore

diff --git a/tools/power/pm-graph/.gitignore b/tools/power/pm-graph/.gitignore
new file mode 100644
index 000000000000..37762a8a06d6
--- /dev/null
+++ b/tools/power/pm-graph/.gitignore
@@ -0,0 +1,3 @@
+# sleepgraph.py artifacts
+suspend-[0-9]*-[0-9]*
+suspend-[0-9]*-[0-9]*-x[0-9]*
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] pm-graph: ignore sleepgraph.py artifacts
  2024-08-25  9:53 [PATCH] pm-graph: ignore sleepgraph.py artifacts Yo-Jung (Leo) Lin
@ 2024-08-26 20:30 ` Todd Brandt
  2024-08-26 20:49 ` Todd Brandt
  1 sibling, 0 replies; 4+ messages in thread
From: Todd Brandt @ 2024-08-26 20:30 UTC (permalink / raw)
  To: Yo-Jung (Leo) Lin
  Cc: linux-kernel-mentees, ricardo, skhan, linux-kernel, linux-pm

On Sun, 2024-08-25 at 17:53 +0800, Yo-Jung (Leo) Lin wrote:
> By default, sleepgraph.py creates suspend-{date}-{time} directories
> to store artifacts, or suspend-{date}-{time}-xN if the --multi option
> is used. Ignore those directories by adding a .gitignore file.
> 
> Signed-off-by: Yo-Jung (Leo) Lin <0xff07@gmail.com>
> ---
>  tools/power/pm-graph/.gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>  create mode 100644 tools/power/pm-graph/.gitignore
> 
> diff --git a/tools/power/pm-graph/.gitignore b/tools/power/pm-
> graph/.gitignore
> new file mode 100644
> index 000000000000..37762a8a06d6
> --- /dev/null
> +++ b/tools/power/pm-graph/.gitignore
> @@ -0,0 +1,3 @@
> +# sleepgraph.py artifacts
> +suspend-[0-9]*-[0-9]*
> +suspend-[0-9]*-[0-9]*-x[0-9]*
This seems fine. If you run the tool inside the tools/power/pm-graph
folder I can see how it would be annoying to have all those output
directories show up in git status.

Signed-off-by: Todd Brandt <todd.e.brandt@linux.intel.com>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pm-graph: ignore sleepgraph.py artifacts
  2024-08-25  9:53 [PATCH] pm-graph: ignore sleepgraph.py artifacts Yo-Jung (Leo) Lin
  2024-08-26 20:30 ` Todd Brandt
@ 2024-08-26 20:49 ` Todd Brandt
  2024-09-04 12:33   ` Rafael J. Wysocki
  1 sibling, 1 reply; 4+ messages in thread
From: Todd Brandt @ 2024-08-26 20:49 UTC (permalink / raw)
  To: Yo-Jung (Leo) Lin
  Cc: linux-kernel-mentees, ricardo, skhan, linux-kernel, linux-pm

On Sun, 2024-08-25 at 17:53 +0800, Yo-Jung (Leo) Lin wrote:
> By default, sleepgraph.py creates suspend-{date}-{time} directories
> to store artifacts, or suspend-{date}-{time}-xN if the --multi option
> is used. Ignore those directories by adding a .gitignore file.
> 
> Signed-off-by: Yo-Jung (Leo) Lin <0xff07@gmail.com>
> ---
>  tools/power/pm-graph/.gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>  create mode 100644 tools/power/pm-graph/.gitignore
> 
> diff --git a/tools/power/pm-graph/.gitignore b/tools/power/pm-
> graph/.gitignore
> new file mode 100644
> index 000000000000..37762a8a06d6
> --- /dev/null
> +++ b/tools/power/pm-graph/.gitignore
> @@ -0,0 +1,3 @@
> +# sleepgraph.py artifacts
> +suspend-[0-9]*-[0-9]*
> +suspend-[0-9]*-[0-9]*-x[0-9]*
This seems fine. If you run the tool inside the tools/power/pm-graph
folder I can see how it would be annoying to have all those output
directories show up in git status. (re-send with Acked-by)

Acked-by: Todd Brandt <todd.e.brandt@linux.intel.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pm-graph: ignore sleepgraph.py artifacts
  2024-08-26 20:49 ` Todd Brandt
@ 2024-09-04 12:33   ` Rafael J. Wysocki
  0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2024-09-04 12:33 UTC (permalink / raw)
  To: todd.e.brandt, Yo-Jung (Leo) Lin
  Cc: linux-kernel-mentees, ricardo, skhan, linux-kernel, linux-pm

On Mon, Aug 26, 2024 at 10:49 PM Todd Brandt
<todd.e.brandt@linux.intel.com> wrote:
>
> On Sun, 2024-08-25 at 17:53 +0800, Yo-Jung (Leo) Lin wrote:
> > By default, sleepgraph.py creates suspend-{date}-{time} directories
> > to store artifacts, or suspend-{date}-{time}-xN if the --multi option
> > is used. Ignore those directories by adding a .gitignore file.
> >
> > Signed-off-by: Yo-Jung (Leo) Lin <0xff07@gmail.com>
> > ---
> >  tools/power/pm-graph/.gitignore | 3 +++
> >  1 file changed, 3 insertions(+)
> >  create mode 100644 tools/power/pm-graph/.gitignore
> >
> > diff --git a/tools/power/pm-graph/.gitignore b/tools/power/pm-
> > graph/.gitignore
> > new file mode 100644
> > index 000000000000..37762a8a06d6
> > --- /dev/null
> > +++ b/tools/power/pm-graph/.gitignore
> > @@ -0,0 +1,3 @@
> > +# sleepgraph.py artifacts
> > +suspend-[0-9]*-[0-9]*
> > +suspend-[0-9]*-[0-9]*-x[0-9]*
> This seems fine. If you run the tool inside the tools/power/pm-graph
> folder I can see how it would be annoying to have all those output
> directories show up in git status. (re-send with Acked-by)
>
> Acked-by: Todd Brandt <todd.e.brandt@linux.intel.com>

Applied as 6.12 material, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-09-04 12:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-25  9:53 [PATCH] pm-graph: ignore sleepgraph.py artifacts Yo-Jung (Leo) Lin
2024-08-26 20:30 ` Todd Brandt
2024-08-26 20:49 ` Todd Brandt
2024-09-04 12:33   ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).