linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>, linux-pm@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	zhangqing@rock-chips.com, zyw@rock-chips.com,
	jon.lin@rock-chips.com, maccraft123mc@gmail.com, sre@kernel.org,
	heiko@sntech.de, krzk+dt@kernel.org, robh+dt@kernel.org,
	lee.jones@linaro.org, Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 1/4 v5] dt-bindings: Add Rockchip rk817 battery charger support
Date: Tue, 5 Apr 2022 16:02:23 +0200	[thread overview]
Message-ID: <7ee4c8ab-595e-eaab-6f52-a97255ec032a@linaro.org> (raw)
In-Reply-To: <20220404215754.30126-2-macroalpha82@gmail.com>

On 04/04/2022 23:57, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Create dt-binding documentation to document rk817 battery and charger
> usage. New device-tree properties have been added.

"Add new devicetree properties." instead of mixing tenses.

> +
> +      rockchip,sleep-filter-current-microamp:
> +        description:
> +          Value in microamps of the sleep filter current for the charger.
> +          Value is used by the driver to derive the sleep sample current.
> +
> +    required:
> +      - monitored-battery
> +      - rockchip,resistor-sense-micro-ohms
> +      - rockchip,sleep-enter-current-microamp
> +      - rockchip,sleep-filter-current-microamp

additionalProperties:false (on required-level of indentation)


Best regards,
Krzysztof

  parent reply	other threads:[~2022-04-05 21:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04 21:57 [PATCH 0/4 v5] power: supply: Add Support for RK817 Charger Chris Morgan
2022-04-04 21:57 ` [PATCH 1/4 v5] dt-bindings: Add Rockchip rk817 battery charger support Chris Morgan
2022-04-05 11:16   ` Krzysztof Kozlowski
2022-04-05 13:12     ` Chris Morgan
2022-04-05 13:35       ` Krzysztof Kozlowski
2022-04-05 13:54         ` Chris Morgan
2022-04-05 14:00           ` Krzysztof Kozlowski
2022-04-05 14:04             ` Chris Morgan
2022-04-06  7:28               ` Krzysztof Kozlowski
2022-04-05 14:02   ` Krzysztof Kozlowski [this message]
2022-04-05 18:23   ` Rob Herring
2022-04-05 18:37     ` Chris Morgan
2022-04-04 21:57 ` [PATCH 2/4 v5] mfd: " Chris Morgan
2022-04-04 21:57 ` [PATCH 3/4 v5] power: supply: Add charger driver for Rockchip RK817 Chris Morgan
2022-04-04 21:57 ` [PATCH 4/4 v5] arm64: dts: rockchip: add rk817 chg to Odroid Go Advance Chris Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ee4c8ab-595e-eaab-6f52-a97255ec032a@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jon.lin@rock-chips.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maccraft123mc@gmail.com \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=zhangqing@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).