From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D86C43217 for ; Thu, 29 Sep 2022 23:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbiI2X5J (ORCPT ); Thu, 29 Sep 2022 19:57:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229798AbiI2X5I (ORCPT ); Thu, 29 Sep 2022 19:57:08 -0400 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94D4CDD340 for ; Thu, 29 Sep 2022 16:57:07 -0700 (PDT) Received: by mail-pj1-f43.google.com with SMTP id gf8so208539pjb.5 for ; Thu, 29 Sep 2022 16:57:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=0hiOmFNw3vUr1qIQOZ1iJJ1qBvLhM6j/K3PWxBaYczc=; b=hZSM/Ea86hl75XXwme4ov/G6eMWKNygw1M86YA/i5tNnUbj4EZtxwGid5tN/3eECDT BhQDE+P7GEF+Qcz9h6AqZvxl2HZVX5yTkW3xVBy12j/8DiYtm6BtPad7U5q4WyGmm5Kg 153yKPpw0eavAhe6QvU2GEXW6syhkPgCezNrNw+z6jBUc1idoE728w9vLHwy5hJivwqL vPaC/5nddHMjxvqYTYeu3bCOmn2PPFYjTpsGNfu3RyTxtVbuqaStci/eLUIBnedGEKUN s3kA4ITmsBab1LG7PjeB+jKAJ9Z7w8b4DdUtgSLcsBk3GuCZBuH2sgBPq6wEbT+iCkCh SV9A== X-Gm-Message-State: ACrzQf2ptPKfik5Zxg93UE4+WT3c1u8/x6rRLf0Axxt6ubx39Gl8INDy Bj7q7ztZxMjcZA0mSmVXQV7lrg== X-Google-Smtp-Source: AMsMyM7RickZmWvA5nYIbma/BzAEICuH8mn9KHWobs8Qk2wZLETHH9DVEjzYRV8475r2zCKl7GjRzg== X-Received: by 2002:a17:90a:fd8c:b0:200:8cf9:63f4 with SMTP id cx12-20020a17090afd8c00b002008cf963f4mr6362140pjb.201.1664495827086; Thu, 29 Sep 2022 16:57:07 -0700 (PDT) Received: from localhost ([75.172.140.17]) by smtp.gmail.com with ESMTPSA id v6-20020a17090a0c8600b001fd9c63e56bsm4035477pja.32.2022.09.29.16.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 16:57:06 -0700 (PDT) From: Kevin Hilman To: Johan Hovold , "Rafael J. Wysocki" , Ulf Hansson Cc: Greg Kroah-Hartman , Matthias Kaehlcke , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: Re: [PATCH] PM: domains: log failures to register always-on domains In-Reply-To: <20220929154214.7305-1-johan+linaro@kernel.org> References: <20220929154214.7305-1-johan+linaro@kernel.org> Date: Thu, 29 Sep 2022 16:57:05 -0700 Message-ID: <7h7d1lwx7y.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Johan Hovold writes: > Always-on PM domains must be on during initialisation or the domain is > currently silently rejected. > > Print an error message in case an always-on domain is not on to make it > easier to debug drivers getting this wrong (e.g. by setting an always-on > genpd flag without making sure that the state matches). > > Signed-off-by: Johan Hovold Reviewed-by: Kevin Hilman > --- > drivers/base/power/domain.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > > Both myself and Matthias have hit this with the Qualcomm GCC drivers > when updating static genpd flags directly instead of using/adding driver > specific flags to propagate the setting. > > Johan > > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index bbfbf05b3446..7200e307effb 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2087,8 +2087,10 @@ int pm_genpd_init(struct generic_pm_domain *genpd, > > /* Always-on domains must be powered on at initialization. */ > if ((genpd_is_always_on(genpd) || genpd_is_rpm_always_on(genpd)) && > - !genpd_status_on(genpd)) > + !genpd_status_on(genpd)) { > + pr_err("always-on PM domain %s is not on\n", genpd->name); > return -EINVAL; > + } > > /* Multiple states but no governor doesn't make sense. */ > if (!gov && genpd->state_count > 1) > -- > 2.35.1