From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBCEE22A7E8 for ; Thu, 8 May 2025 13:14:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746710051; cv=none; b=MMAI2PNQx3DCUXHEpj/tSwR+f7f2RoSz4AvcuIx1gC4BoaiAwG1FkbFSrMm7tsEo0a0dwnZSJd4ARUUL8xU1ns4kvM4KRzX74nE/eEuHj62Jq51bfx3DRLebixdh91/yg83JzMrwB0NnSpEEbq/PDJJhe7n3IBES9qD1JMYnmO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746710051; c=relaxed/simple; bh=9mXvjbwW8ofidBphHEKQjhYR9ffb1wijcx8qRAM1zG0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=f+LKjXP3XUDKjrAwfy7z7DvDke7SrF/3VP3THRQFwDAkHejQwP8/ab2Ao6DlJ2exs+f9I+ghMa3y4W4lC40yiR5zjYoOkJe9fb40qvA8id4bqD5SwrOMpbfp4NvXAE7HMAQo6WYkRHgdw98EVbVkm59VMyZgJbXLQiHZxJoW/YQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ULhribNO; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ULhribNO" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7376dd56eccso1023676b3a.0 for ; Thu, 08 May 2025 06:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1746710049; x=1747314849; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=W0ynFZEEXAjIagoyl65aQJ9Sy+zKGYCNgLUwmb5k0MA=; b=ULhribNOHgS+4z/WEc7xhhmKIDRR6VIBr1EEOjDNxPbEkAeMWSEp9M+NnfUays2k/+ POuE4Py6xtJPh2MeEVaIzgqCgUL3+ZQv23FFZrG+7XvPPQ36jG7+9JheUTrL3kvqXzTm rTGIv+JVBPIxmBmey0cpOnKPL3H7y+Q/Owz9H4w4rbt8JmSgpcMiyw6zXt8JCGWRDmSz AQ7Jed6CBHSaFiTTsgajOo/wPxOUlc8u6FBCYXqg36dkKpQfS+V8A4MOcK7PDo8qil0P Qm5Ut2UXoJ0FNYxjsU3zmnAVwouDDG6fUP4fws/zvnWLax1JDoSnYavqSdryaaeBFSSw 2uWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746710049; x=1747314849; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W0ynFZEEXAjIagoyl65aQJ9Sy+zKGYCNgLUwmb5k0MA=; b=GmFNbENKh9QJ2e05hzZgWkvnDiw9zr60FHUAyGlHYtZf7RPStQG4pjSwrlBColR2lQ h2ks4xDCluGlvk2mBD8t8ErdjmrG64IPbrjhDUTm+LAkgaSrZSyBMO4bB9iIpEiw0gQF fOAdYU6Ss8Be1t/FFPdvzNoWcSX7KfYXTb6R4KeY7wsZ3R+PGoy4rCO2UQ7v+YK05Dap nczbKqV2i8HfhvAO8IbwY3mZXMVR3zI8FD67vNo6bNNpQP7Dgchx2TqrXo3LFQiwCyOq DAic4OpDFRDs0JAp321eUvJWsCJHihxU4JzAU+aCFShFbVJ0Ly0NMsJX2OFEYyo+V6rK stow== X-Forwarded-Encrypted: i=1; AJvYcCXukYwR3G2sJ+Qq6skNbjrQJK2rlAJTu12rvxP75R++cdGebyUv5wM+MPTW6s86dYPr+lmjWZK/Rg==@vger.kernel.org X-Gm-Message-State: AOJu0Yx2jJb/pMMLsVBpb7GeAQiFEPN7NfxnRpYrEvMrz8nrpWSSr4Y6 q1gkNEgp/qzxCOHCXUkEaRcqEQsdMUu9whObh0sKgZKM0swMbvH/OP8aozW6eqA= X-Gm-Gg: ASbGnctpJE8zoHKCDB/jgMJKAKqrLDFRGfy1N+K5VlImuT1AsmvGdqiacj2GAqXMEDw SYQ6x9VvpD8BbH9OgXRdirswMnI1owNsxwz7XkGeEcqUeJu1CNk4SXtfIFzsHEHnAZDZxdhkzz5 T9L4MLT1F/6OIjOAxl10pis/PLISWGPfuuQTg42ASouUq9RqY80lG2xXumbei9xu9+dkNES7RK+ wpmxCPNPD8QK1GY8lPUK0ljdCf876+GsuF+lVIAUlJOJoWX2KdHHUCu53XW0W1SaCPDS0MMXZSe CVkyQ1lAFUVOT286TUgqEJ1gJ3S7n43OKfCagJQ= X-Google-Smtp-Source: AGHT+IFA5bdAR+g+8jas/pp/moZKFd/5kEN1qQAf++05eckooX+tTxGDVWyNcpdJrbek7kiTWc5H5g== X-Received: by 2002:a05:6a00:2887:b0:736:73ad:365b with SMTP id d2e1a72fcca58-740a99b3b98mr5056194b3a.14.1746710048945; Thu, 08 May 2025 06:14:08 -0700 (PDT) Received: from localhost ([97.126.182.119]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7405905d067sm13158112b3a.126.2025.05.08.06.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 06:14:08 -0700 (PDT) From: Kevin Hilman To: Sukrut Bellary , Russell King , Rob Herring , Tony Lindgren , Krzysztof Kozlowski , Nishanth Menon , Ulf Hansson Cc: Sukrut Bellary , Aaro Koskinen , Andreas Kemnade , Roger Quadros , Conor Dooley , Santosh Shilimkar , Bajjuri Praneeth , Raghavendra Vignesh , Bin Liu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/4] pmdomain: ti: Fix STANDBY handling of PER power domain In-Reply-To: <20250318230042.3138542-3-sbellary@baylibre.com> References: <20250318230042.3138542-1-sbellary@baylibre.com> <20250318230042.3138542-3-sbellary@baylibre.com> Date: Thu, 08 May 2025 06:14:07 -0700 Message-ID: <7hjz6rtfc0.fsf@baylibre.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Sukrut Bellary writes: > Per AM335x TRM[1](section 8.1.4.3 Power mode), in case of STANDBY, > PER domain should be ON. So, fix the PER power domain handling on standby. > > [1] https://www.ti.com/lit/ug/spruh73q/spruh73q.pdf > > Signed-off-by: Sukrut Bellary Reviewed-by: Kevin Hilman Ulf, this series has been tested now. Go ahead and take this patch. Thanks, Kevin > --- > drivers/pmdomain/ti/omap_prm.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/pmdomain/ti/omap_prm.c b/drivers/pmdomain/ti/omap_prm.c > index b8ceb3c2b81c..7e36e675a8c6 100644 > --- a/drivers/pmdomain/ti/omap_prm.c > +++ b/drivers/pmdomain/ti/omap_prm.c > @@ -18,7 +18,9 @@ > #include > #include > #include > - > +#if IS_ENABLED(CONFIG_SUSPEND) > +#include > +#endif > #include > > enum omap_prm_domain_mode { > @@ -88,6 +90,7 @@ struct omap_reset_data { > #define OMAP_PRM_HAS_RSTST BIT(1) > #define OMAP_PRM_HAS_NO_CLKDM BIT(2) > #define OMAP_PRM_RET_WHEN_IDLE BIT(3) > +#define OMAP_PRM_ON_WHEN_STANDBY BIT(4) > > #define OMAP_PRM_HAS_RESETS (OMAP_PRM_HAS_RSTCTRL | OMAP_PRM_HAS_RSTST) > > @@ -404,7 +407,8 @@ static const struct omap_prm_data am3_prm_data[] = { > .name = "per", .base = 0x44e00c00, > .pwrstctrl = 0xc, .pwrstst = 0x8, .dmap = &omap_prm_noinact, > .rstctrl = 0x0, .rstmap = am3_per_rst_map, > - .flags = OMAP_PRM_HAS_RSTCTRL, .clkdm_name = "pruss_ocp" > + .flags = OMAP_PRM_HAS_RSTCTRL | OMAP_PRM_ON_WHEN_STANDBY, > + .clkdm_name = "pruss_ocp", > }, > { > .name = "wkup", .base = 0x44e00d00, > -- > 2.34.1