* [PATCH v2] PM / AVS: rockchip-io: Fix module autoload for OF platform driver
@ 2015-10-02 14:27 Luis de Bethencourt
2015-10-12 18:25 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Luis de Bethencourt @ 2015-10-02 14:27 UTC (permalink / raw)
To: linux-kernel, rafael.j.wysocki
Cc: khilman, nm, heiko, linux-pm, linux-arm-kernel, linux-rockchip,
Luis de Bethencourt
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---
Hello,
Sending a second version to add Rafael Wysocki in the to-list as
suggested by Heiko Stübner.
https://lkml.org/lkml/2015/10/2/431
This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.
A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519
Thanks,
Luis
drivers/power/avs/rockchip-io-domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/avs/rockchip-io-domain.c b/drivers/power/avs/rockchip-io-domain.c
index 2e30002..8099456 100644
--- a/drivers/power/avs/rockchip-io-domain.c
+++ b/drivers/power/avs/rockchip-io-domain.c
@@ -271,6 +271,7 @@ static const struct of_device_id rockchip_iodomain_match[] = {
},
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(of, rockchip_iodomain_match);
static int rockchip_iodomain_probe(struct platform_device *pdev)
{
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] PM / AVS: rockchip-io: Fix module autoload for OF platform driver
2015-10-02 14:27 [PATCH v2] PM / AVS: rockchip-io: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-10-12 18:25 ` Kevin Hilman
2015-10-15 0:35 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2015-10-12 18:25 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-kernel, rafael.j.wysocki, nm, heiko, linux-pm,
linux-arm-kernel, linux-rockchip
Luis de Bethencourt <luisbg@osg.samsung.com> writes:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Kevin Hilman <khilman@linaro.org>
Rafael, feel free to apply directly.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] PM / AVS: rockchip-io: Fix module autoload for OF platform driver
2015-10-12 18:25 ` Kevin Hilman
@ 2015-10-15 0:35 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2015-10-15 0:35 UTC (permalink / raw)
To: Kevin Hilman
Cc: Luis de Bethencourt, linux-kernel, rafael.j.wysocki, nm, heiko,
linux-pm, linux-arm-kernel, linux-rockchip
On Monday, October 12, 2015 11:25:54 AM Kevin Hilman wrote:
> Luis de Bethencourt <luisbg@osg.samsung.com> writes:
>
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> >
> > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> Acked-by: Kevin Hilman <khilman@linaro.org>
>
> Rafael, feel free to apply directly.
Done.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-15 0:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-02 14:27 [PATCH v2] PM / AVS: rockchip-io: Fix module autoload for OF platform driver Luis de Bethencourt
2015-10-12 18:25 ` Kevin Hilman
2015-10-15 0:35 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).