From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 0/3] Introduce SET_NOIRQ_SYSTEM_SLEEP_PM_OPS and use it Date: Tue, 28 Apr 2015 08:40:04 -0700 Message-ID: <7hr3r4w9bf.fsf@linaro.org> References: <1430159072-31440-1-git-send-email-grygorii.strashko@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:33477 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030288AbbD1PkG (ORCPT ); Tue, 28 Apr 2015 11:40:06 -0400 Received: by pacwv17 with SMTP id wv17so146048980pac.0 for ; Tue, 28 Apr 2015 08:40:06 -0700 (PDT) In-Reply-To: <1430159072-31440-1-git-send-email-grygorii.strashko@linaro.org> (grygorii strashko's message of "Mon, 27 Apr 2015 21:24:29 +0300") Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: grygorii.strashko@linaro.org Cc: "Rafael J. Wysocki" , Pavel Machek , Len Brown , linux-pm@vger.kernel.org, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Lindgren , Nishanth Menon , Santosh Shilimkar writes: > From: Grygorii Strashko > > While working on suspend-to-disk functionality on TI dra7-evm (DRA7xx SoC) > i've found that the most common problem I have to dial with is absence > of corresponding PM callbacks in drivers and, in particular, noirq callbacks. > So, I've fixed one driver first > commit 6248015d6867 "ARM: omap-device: add missed callback for suspend-to-disk" > but then found another one which need to be fixed too (omap_l3_noc.c). > At this moment I decided to make my life easier and added new macro > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS using the same approach as for the existing > SET_SYSTEM_SLEEP_PM_OPS macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS: defined for CONFIG_PM_SLEEP and > assigns ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. > > Further two patches reuse this newly introduced macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, defined for CONFIG_PM_SLEEP, will > point ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. For the series: Reviewed-by: Kevin Hilman And for the omap_device changes: Acked-by: Kevin Hilman