From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 315BD1AD5CB for ; Thu, 5 Sep 2024 21:58:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725573492; cv=none; b=VIBCtx12+uwiut+Nv1TCSViMWxn0fXs3sJRUo1kgaEaAgMbpbcSgP2ywueCgISaFuhRl/i7LZZ3Un57jUWNVUFclBtHrQWSBWx5wRA8N1aaV4oIooo579nFR+t4wEkBbyU4mVFGD3uez7YkzitPJ9YNjXvG7us1JJH3Js40aPVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725573492; c=relaxed/simple; bh=e9rxq9LZX+91CbA6ojRIObEYeB2nV1V6Dz73whegJ1I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=cwm5tylb5bADOnG7XcQw5wM+prApyMEq9YjPWq2SYve9EzYOU6HjJkSjc26x28QuG8jAHsbBE/4bCH5jDO098PIsSpi/jpPiy8LQeorRLeI+/FqX7IcwUwaoP4u9fu5kY//xMpBOzC1LkX7oIRDI5bY1gRzt0JNZSf+6ftRocsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dQZhzunV; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dQZhzunV" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7c691c8f8dcso961555a12.1 for ; Thu, 05 Sep 2024 14:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725573490; x=1726178290; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=debuxuNcW7Vau/i5ri1+uD5qWokdP8/oPSvRGMK4Oy4=; b=dQZhzunVTQ60/9d4z/JGsQAd/R3jMugvuAb0eh1kmrmQo55oP+gHj+SBi3HUtSVzz0 TD9rblT2U1DvQNpudcWYtQQmM5V2Xc1y/ZJjVjfUn3LCXn/9JYeqk/2u3TbKTI4wi9Y2 a0dyjrsAgMxMIbI2RBHdfPP0GzkGdLFNylsILcfXFMU/V269jaACefUEpZjY1gd9Z9AQ aoiQ7UZsZFoQdYYon9RIgfP/JlQQYjIzG5rK7pI2vXVOgKO1/2zKAVbKEzCXR7JfGJF0 eM4Tovyj6nkf4UMtLyY+mw5YmBwx34VexDqCEQbdHrf/kpZoN/BMjbTflthZK6NDBA/C g4fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725573490; x=1726178290; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=debuxuNcW7Vau/i5ri1+uD5qWokdP8/oPSvRGMK4Oy4=; b=w/e6/moVcS6Yp7p44IVbXF/PUNZwHw8Q65N6ITH+V0JZFaHOmBO/rCLIC2SnsAnguX JqLVlZumt0cU+BUL0Mc2M+g6RwlDR1R9v/OKuVbSmrDqubf6jEIs14yKYzsQbW7OYtyg mO/IDo67C60DzIPE2fuucntnOqTie9vdgw3ZxnOMqhQiNYQd+6OyLkEr/TNaQ0IGHZR0 FULryV5HklbmtkgvOBQrTA+SuI75v1YGkRx7gWyLX00zbfdqnpc9RRyi47LDi2PSTYOy rdRGrPvz5yPfcwaUpFaKly/TS9qjTUSmAOUol3JdcB3+ZCVHl7U2RgVwaEEDBEtfdA0P YPDg== X-Gm-Message-State: AOJu0Yw7oYMo9I0J4UqypvnkPyD9HMUwaMvKo3CRzJNJ4K+t7fFOs+Vp /9RqwFVBsjLVp3788ve8QHubj3jb+tU00GWbKaKeCmdUhp1UY8xj8/lnMhOCWR5qlKQgMmjA3Ke zRX8= X-Google-Smtp-Source: AGHT+IGTshBMlJFlXsC+frdPM3BZscmeS6VUJgi2fVQqYwOBl4sze3V53Rb4d0wn1FbyDqYcOILusQ== X-Received: by 2002:a17:90a:f48e:b0:2d8:7a3b:730d with SMTP id 98e67ed59e1d1-2dad501408fmr847011a91.21.1725573490526; Thu, 05 Sep 2024 14:58:10 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dadbff3c6dsm6637a91.3.2024.09.05.14.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 14:58:10 -0700 (PDT) From: Kevin Hilman To: Ulf Hansson Cc: linux-pm@vger.kernel.org, Nishanth Menon , Vibhore Vardhan , Dhruva Gole , Akashdeep Kaur , Sebin Francis , Markus Schneider-Pargmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] pmdomain: ti_sci: add wakeup constraint management In-Reply-To: References: <20240819-lpm-v6-10-constraints-pmdomain-v2-0-461325a6008f@baylibre.com> <20240819-lpm-v6-10-constraints-pmdomain-v2-2-461325a6008f@baylibre.com> Date: Thu, 05 Sep 2024 14:58:09 -0700 Message-ID: <7hseudahla.fsf@baylibre.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Ulf Hansson writes: > On Tue, 20 Aug 2024 at 02:00, Kevin Hilman wrote: >> >> During system-wide suspend, check all devices connected to PM domain >> to see if they are wakeup-enabled. If so, set a TI SCI device >> constraint. >> >> Note: DM firmware clears all constraints on resume. >> >> Co-developed-by: Vibhore Vardhan >> Signed-off-by: Vibhore Vardhan >> Signed-off-by: Kevin Hilman >> Signed-off-by: Dhruva Gole >> --- >> drivers/pmdomain/ti/ti_sci_pm_domains.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c >> index 963272fa387b..8af907579152 100644 >> --- a/drivers/pmdomain/ti/ti_sci_pm_domains.c >> +++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c >> @@ -76,6 +76,23 @@ static int ti_sci_pd_set_lat_constraint(struct device *dev, s32 val) >> return ret; >> } >> >> +static inline bool ti_sci_pd_set_wkup_constraint(struct device *dev) >> +{ > > Similar comment as for patch1, should this be a static void intstead? > Yes, will do in v3. Kevin