* [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed.
[not found] <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de>
@ 2018-12-02 20:52 ` Thomas Meyer
2018-12-11 18:53 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Meyer @ 2018-12-02 20:52 UTC (permalink / raw)
To: khilman, nm, linux-pm, linux-kernel
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
--- a/drivers/power/avs/smartreflex.c
+++ b/drivers/power/avs/smartreflex.c
@@ -1010,8 +1010,7 @@ static int omap_sr_remove(struct platfor
if (sr_info->autocomp_active)
sr_stop_vddautocomp(sr_info);
- if (sr_info->dbg_dir)
- debugfs_remove_recursive(sr_info->dbg_dir);
+ debugfs_remove_recursive(sr_info->dbg_dir);
pm_runtime_disable(&pdev->dev);
list_del(&sr_info->node);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed.
2018-12-02 20:52 ` [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed Thomas Meyer
@ 2018-12-11 18:53 ` Kevin Hilman
2018-12-17 11:45 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2018-12-11 18:53 UTC (permalink / raw)
To: Thomas Meyer, khilman, nm, linux-pm, linux-kernel
Thomas Meyer <thomas@m3y3r.de> writes:
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> ---
>
> diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -1010,8 +1010,7 @@ static int omap_sr_remove(struct platfor
>
> if (sr_info->autocomp_active)
> sr_stop_vddautocomp(sr_info);
> - if (sr_info->dbg_dir)
> - debugfs_remove_recursive(sr_info->dbg_dir);
> + debugfs_remove_recursive(sr_info->dbg_dir);
>
> pm_runtime_disable(&pdev->dev);
> list_del(&sr_info->node);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed.
2018-12-11 18:53 ` Kevin Hilman
@ 2018-12-17 11:45 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-12-17 11:45 UTC (permalink / raw)
To: Kevin Hilman, Thomas Meyer; +Cc: khilman, nm, linux-pm, linux-kernel
On Tuesday, December 11, 2018 7:53:05 PM CET Kevin Hilman wrote:
> Thomas Meyer <thomas@m3y3r.de> writes:
>
> > NULL check before some freeing functions is not needed.
> >
> > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
>
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
>
> > ---
> >
> > diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> > --- a/drivers/power/avs/smartreflex.c
> > +++ b/drivers/power/avs/smartreflex.c
> > @@ -1010,8 +1010,7 @@ static int omap_sr_remove(struct platfor
> >
> > if (sr_info->autocomp_active)
> > sr_stop_vddautocomp(sr_info);
> > - if (sr_info->dbg_dir)
> > - debugfs_remove_recursive(sr_info->dbg_dir);
> > + debugfs_remove_recursive(sr_info->dbg_dir);
> >
> > pm_runtime_disable(&pdev->dev);
> > list_del(&sr_info->node);
>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-17 11:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de>
2018-12-02 20:52 ` [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed Thomas Meyer
2018-12-11 18:53 ` Kevin Hilman
2018-12-17 11:45 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).