From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: 최찬우 <cw00.choi@samsung.com>, "Dan Carpenter" <dan.carpenter@oracle.com>
Cc: 박경민 <kyungmin.park@samsung.com>, "Kukjin Kim" <kgene@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: Re: [patch] PM / devfreq: event: testing the wrong variable
Date: Thu, 12 Feb 2015 09:00:43 +0000 (GMT) [thread overview]
Message-ID: <808951994.1086901423731642675.JavaMail.weblogic@epmlwas01a> (raw)
>
> On 02/10/2015 07:35 PM, Dan Carpenter wrote:
> > There is a typo here so we test "edev" but we intended to test
> > "edev[i]".
> >
> > Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> > index 135be0a..ad83473 100644
> > --- a/drivers/devfreq/event/exynos-ppmu.c
> > +++ b/drivers/devfreq/event/exynos-ppmu.c
> > @@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
> > - if (IS_ERR(edev)) {
> > - ret = PTR_ERR(edev);
> > + if (IS_ERR(edev[i])) {
> > + ret = PTR_ERR(edev[i]);
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> But,
> This patch has not yet merged to linux.git (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git).
> After releasing Linux 3.20-rc1, this patch will be handled.
>
> Thanks,
> Chanwoo Choi
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
reply other threads:[~2015-02-12 9:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=808951994.1086901423731642675.JavaMail.weblogic@epmlwas01a \
--to=myungjoo.ham@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox