From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95037C433DB for ; Thu, 25 Feb 2021 14:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A23E64F0C for ; Thu, 25 Feb 2021 14:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231942AbhBYOS3 (ORCPT ); Thu, 25 Feb 2021 09:18:29 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:13378 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231414AbhBYOS3 (ORCPT ); Thu, 25 Feb 2021 09:18:29 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DmZZx32Dhz7q8b; Thu, 25 Feb 2021 22:16:09 +0800 (CST) Received: from [10.174.178.147] (10.174.178.147) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Thu, 25 Feb 2021 22:17:40 +0800 Subject: Re: [PATCH v1 1/4] ACPI: processor: Get rid of ACPICA message printing To: "Rafael J. Wysocki" CC: "Rafael J. Wysocki" , Linux ACPI , Linux PM , LKML References: <5138173.kHyPcihzTF@kreacher> <10245832.OiMb8u2cOm@kreacher> <0faea0bd-107b-5c4c-5324-e0cd5e5cfba4@huawei.com> From: Hanjun Guo Message-ID: <816edceb-983b-03d7-4a96-d325658417fd@huawei.com> Date: Thu, 25 Feb 2021 22:17:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.147] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 2021/2/25 2:06, Rafael J. Wysocki wrote: > On Tue, Feb 23, 2021 at 3:45 PM Rafael J. Wysocki wrote: >> >> On Tue, Feb 23, 2021 at 12:31 PM Hanjun Guo wrote: >>> >>> On 2021/2/23 2:59, Rafael J. Wysocki wrote: >>>> Index: linux-pm/drivers/acpi/processor_idle.c >>>> =================================================================== >>>> --- linux-pm.orig/drivers/acpi/processor_idle.c >>>> +++ linux-pm/drivers/acpi/processor_idle.c >>> >>> In this file, function acpi_processor_cstate_first_run_checks() >>> has a wrong pr_notice(): >>> >>> pr_notice("ACPI: processor limited to max C-state %d\n", >>> max_cstate); >>> >>> Since we have pr_fmt() for this file, "ACPI:" is duplicate, >>> we'd better cleanup this as below: >>> >>> pr_notice("processor limited to max C-state %d\n", max_cstate); >> >> Thanks for pointing this out, I'll make this change when applying the patch. > > Actually, this issue is not strictly related to the patch here, so I'm > going to send a separate patch to fix it. Make sense to me as well. Thanks Hanjun