public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Guilhem Lettron <guilhem@barpilot.io>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Len Brown <lenb@kernel.org>, Linux PM <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] intel_idle: Add ICL support
Date: Thu, 27 Aug 2020 01:47:44 +0800	[thread overview]
Message-ID: <82c789766e71d29cf1a90f519d21ba310ae8fa95.camel@intel.com> (raw)
In-Reply-To: <CAJZ5v0gJscMWLsjCm_L6jCDdZ2hdRB2mPtUBSgd1va7Xm7GyVA@mail.gmail.com>

On Wed, 2020-08-26 at 19:00 +0200, Rafael J. Wysocki wrote:
> On Wed, Aug 26, 2020 at 6:46 PM Guilhem Lettron <guilhem@barpilot.io>
> wrote:
> > 
> > I've done more tests, maybe it can give you more hints.
> > I don't see that much differences between both (with and without
> > patches) in this cases.
> 
> OK, thanks!
> 
> I'm assuming that the topmost two sets of data are for the "without
> the patch" case whereas the other three correspond to the "with the
> patch" case.

I think the sample period is too short.
Even with the same kernel, I can see the Busy% varies from 1% to 9%,
and the PkgWatt varies from 0.4W to 2.4W.

thanks,
rui

> 
> If so, the processor clearly enters PC10 in both cases and the
> residency percentages are similar.
> 
> The numbers of times the POLL state was selected in the first test
> look kind of unusual (relatively very large), but other than this the
> patch doesn't seem to make much of a difference, so I'm not going to
> apply it.
> 
> Thanks!


  reply	other threads:[~2020-08-26 17:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 12:04 [PATCH] intel_idle: Add ICL support Guilhem Lettron
2020-08-26 12:43 ` Rafael J. Wysocki
2020-08-26 13:03   ` Guilhem Lettron
2020-08-26 13:09     ` Artem Bityutskiy
2020-08-26 13:19       ` Guilhem Lettron
2020-08-26 13:20       ` Rafael J. Wysocki
2020-08-26 13:16     ` Artem Bityutskiy
2020-08-26 13:18       ` Artem Bityutskiy
2020-08-26 13:21         ` Rafael J. Wysocki
2020-08-26 13:32         ` Guilhem Lettron
2020-08-26 13:41           ` Zhang Rui
2020-08-26 14:04             ` Guilhem Lettron
2020-08-26 16:02               ` Rafael J. Wysocki
2020-08-26 16:21                 ` Rafael J. Wysocki
2020-08-26 16:39                 ` Artem Bityutskiy
2020-08-26 16:43                   ` Rafael J. Wysocki
2020-08-26 16:46                     ` Guilhem Lettron
2020-08-26 17:00                       ` Rafael J. Wysocki
2020-08-26 17:47                         ` Zhang Rui [this message]
2020-08-26 16:52                     ` Artem Bityutskiy
2020-08-26 16:19               ` Artem Bityutskiy
2020-08-26 16:25                 ` Artem Bityutskiy
2020-08-26 16:28                   ` Artem Bityutskiy
2020-08-26 16:41                 ` Rafael J. Wysocki
     [not found]   ` <CAGX5Wg0655U71nFcaAJXmj1XMA3MjnCVn=q1Pf=7LLyryHhroQ@mail.gmail.com>
2020-08-26 13:17     ` Rafael J. Wysocki
2020-08-26 13:34       ` Guilhem Lettron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82c789766e71d29cf1a90f519d21ba310ae8fa95.camel@intel.com \
    --to=rui.zhang@intel.com \
    --cc=dedekind1@gmail.com \
    --cc=guilhem@barpilot.io \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox