From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list
Date: Thu, 1 Jun 2017 11:00:56 +0200 [thread overview]
Message-ID: <83a8441d-e07c-c1a8-faa5-28521ea9ab39@microchip.com> (raw)
In-Reply-To: <20170531094915.3469-2-alexandre.belloni@free-electrons.com>
Le 31/05/2017 à 11:49, Alexandre Belloni a écrit :
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
>
> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/power/reset/at91-sama5d2_shdwc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index 90b0b5a70ce5..55fce8b75245 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -132,7 +132,7 @@ static void at91_lpddr_poweroff(void)
> "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
> "r" (at91_shdwc->at91_shdwc_base),
> "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> - : "r0");
> + : "r6");
> }
>
> static u32 at91_shdwc_debouncer_value(struct platform_device *pdev,
>
--
Nicolas Ferre
next prev parent reply other threads:[~2017-06-01 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 9:49 [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Alexandre Belloni
2017-05-31 9:49 ` [PATCH 2/2] power: reset: at91-sama5d2_shdwc: " Alexandre Belloni
2017-06-01 9:00 ` Nicolas Ferre [this message]
2017-06-07 20:50 ` Sebastian Reichel
2017-06-01 9:00 ` [PATCH 1/2] power: reset: at91-poweroff: " Nicolas Ferre
2017-06-07 20:50 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a8441d-e07c-c1a8-faa5-28521ea9ab39@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).