* [PATCH 1/2] power: reset: at91-poweroff: fix clobber list
@ 2017-05-31 9:49 Alexandre Belloni
2017-05-31 9:49 ` [PATCH 2/2] power: reset: at91-sama5d2_shdwc: " Alexandre Belloni
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alexandre Belloni @ 2017-05-31 9:49 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Nicolas Ferre, linux-pm, linux-kernel, linux-arm-kernel,
Alexandre Belloni
Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/power/reset/at91-poweroff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
index c6c3beea72f9..c30c40193aaa 100644
--- a/drivers/power/reset/at91-poweroff.c
+++ b/drivers/power/reset/at91-poweroff.c
@@ -97,7 +97,7 @@ static void at91_lpddr_poweroff(void)
"r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
"r" (at91_shdwc_base),
"r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
- : "r0");
+ : "r6");
}
static int at91_poweroff_get_wakeup_mode(struct device_node *np)
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list
2017-05-31 9:49 [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Alexandre Belloni
@ 2017-05-31 9:49 ` Alexandre Belloni
2017-06-01 9:00 ` Nicolas Ferre
2017-06-07 20:50 ` Sebastian Reichel
2017-06-01 9:00 ` [PATCH 1/2] power: reset: at91-poweroff: " Nicolas Ferre
2017-06-07 20:50 ` Sebastian Reichel
2 siblings, 2 replies; 6+ messages in thread
From: Alexandre Belloni @ 2017-05-31 9:49 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Nicolas Ferre, linux-pm, linux-kernel, linux-arm-kernel,
Alexandre Belloni
Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/power/reset/at91-sama5d2_shdwc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
index 90b0b5a70ce5..55fce8b75245 100644
--- a/drivers/power/reset/at91-sama5d2_shdwc.c
+++ b/drivers/power/reset/at91-sama5d2_shdwc.c
@@ -132,7 +132,7 @@ static void at91_lpddr_poweroff(void)
"r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
"r" (at91_shdwc->at91_shdwc_base),
"r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
- : "r0");
+ : "r6");
}
static u32 at91_shdwc_debouncer_value(struct platform_device *pdev,
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list
2017-05-31 9:49 ` [PATCH 2/2] power: reset: at91-sama5d2_shdwc: " Alexandre Belloni
@ 2017-06-01 9:00 ` Nicolas Ferre
2017-06-07 20:50 ` Sebastian Reichel
1 sibling, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2017-06-01 9:00 UTC (permalink / raw)
To: Alexandre Belloni, Sebastian Reichel
Cc: linux-pm, linux-kernel, linux-arm-kernel
Le 31/05/2017 à 11:49, Alexandre Belloni a écrit :
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
>
> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/power/reset/at91-sama5d2_shdwc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index 90b0b5a70ce5..55fce8b75245 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -132,7 +132,7 @@ static void at91_lpddr_poweroff(void)
> "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
> "r" (at91_shdwc->at91_shdwc_base),
> "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> - : "r0");
> + : "r6");
> }
>
> static u32 at91_shdwc_debouncer_value(struct platform_device *pdev,
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] power: reset: at91-sama5d2_shdwc: fix clobber list
2017-05-31 9:49 ` [PATCH 2/2] power: reset: at91-sama5d2_shdwc: " Alexandre Belloni
2017-06-01 9:00 ` Nicolas Ferre
@ 2017-06-07 20:50 ` Sebastian Reichel
1 sibling, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2017-06-07 20:50 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Nicolas Ferre, linux-pm, linux-kernel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
Hi,
On Wed, May 31, 2017 at 11:49:15AM +0200, Alexandre Belloni wrote:
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
Thanks, queued.
-- Sebastian
> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/power/reset/at91-sama5d2_shdwc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index 90b0b5a70ce5..55fce8b75245 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -132,7 +132,7 @@ static void at91_lpddr_poweroff(void)
> "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
> "r" (at91_shdwc->at91_shdwc_base),
> "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> - : "r0");
> + : "r6");
> }
>
> static u32 at91_shdwc_debouncer_value(struct platform_device *pdev,
> --
> 2.11.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] power: reset: at91-poweroff: fix clobber list
2017-05-31 9:49 [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Alexandre Belloni
2017-05-31 9:49 ` [PATCH 2/2] power: reset: at91-sama5d2_shdwc: " Alexandre Belloni
@ 2017-06-01 9:00 ` Nicolas Ferre
2017-06-07 20:50 ` Sebastian Reichel
2 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2017-06-01 9:00 UTC (permalink / raw)
To: Alexandre Belloni, Sebastian Reichel
Cc: linux-pm, linux-kernel, linux-arm-kernel
Le 31/05/2017 à 11:49, Alexandre Belloni a écrit :
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
>
> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/power/reset/at91-poweroff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
> index c6c3beea72f9..c30c40193aaa 100644
> --- a/drivers/power/reset/at91-poweroff.c
> +++ b/drivers/power/reset/at91-poweroff.c
> @@ -97,7 +97,7 @@ static void at91_lpddr_poweroff(void)
> "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
> "r" (at91_shdwc_base),
> "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> - : "r0");
> + : "r6");
> }
>
> static int at91_poweroff_get_wakeup_mode(struct device_node *np)
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] power: reset: at91-poweroff: fix clobber list
2017-05-31 9:49 [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Alexandre Belloni
2017-05-31 9:49 ` [PATCH 2/2] power: reset: at91-sama5d2_shdwc: " Alexandre Belloni
2017-06-01 9:00 ` [PATCH 1/2] power: reset: at91-poweroff: " Nicolas Ferre
@ 2017-06-07 20:50 ` Sebastian Reichel
2 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2017-06-07 20:50 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Nicolas Ferre, linux-pm, linux-kernel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
Hi,
On Wed, May 31, 2017 at 11:49:14AM +0200, Alexandre Belloni wrote:
> Assembly in at91_lpddr_poweroff has r0 in the clobber list but uses r6.
>
> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Thanks, queued.
-- Sebastian
> ---
> drivers/power/reset/at91-poweroff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
> index c6c3beea72f9..c30c40193aaa 100644
> --- a/drivers/power/reset/at91-poweroff.c
> +++ b/drivers/power/reset/at91-poweroff.c
> @@ -97,7 +97,7 @@ static void at91_lpddr_poweroff(void)
> "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
> "r" (at91_shdwc_base),
> "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> - : "r0");
> + : "r6");
> }
>
> static int at91_poweroff_get_wakeup_mode(struct device_node *np)
> --
> 2.11.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-07 20:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-31 9:49 [PATCH 1/2] power: reset: at91-poweroff: fix clobber list Alexandre Belloni
2017-05-31 9:49 ` [PATCH 2/2] power: reset: at91-sama5d2_shdwc: " Alexandre Belloni
2017-06-01 9:00 ` Nicolas Ferre
2017-06-07 20:50 ` Sebastian Reichel
2017-06-01 9:00 ` [PATCH 1/2] power: reset: at91-poweroff: " Nicolas Ferre
2017-06-07 20:50 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).