From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
sboyd@codeaurora.org, prarit@redhat.com, skannan@codeaurora.org,
Srivatsa Bhat <srivatsa@mit.edu>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V5 08/14] cpufreq: Track cpu managing sysfs kobjects separately
Date: Mon, 18 May 2015 10:43:31 +0530 [thread overview]
Message-ID: <84aa63d8a244c2c7095ff41a2bd0013d8b95f290.1431924457.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1431924457.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1431924457.git.viresh.kumar@linaro.org>
From: Saravana Kannan <skannan@codeaurora.org>
In order to prepare for the next few commits, that will stop migrating
sysfs files on cpu hotplug, this patch starts managing sysfs-cpu
separately.
The behavior is still the same as we are still migrating sysfs files on
hotplug, later commits would change that.
Signed-off-by: Saravana Kannan <skannan@codeaurora.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/cpufreq.c | 11 +++++++----
include/linux/cpufreq.h | 4 +++-
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 983961ba2f72..d7fc3d9294f8 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -966,7 +966,7 @@ static int cpufreq_add_dev_symlink(struct cpufreq_policy *policy)
for_each_cpu(j, policy->cpus) {
struct device *cpu_dev;
- if (j == policy->cpu)
+ if (j == policy->kobj_cpu)
continue;
pr_debug("Adding link for CPU: %u\n", j);
@@ -1185,6 +1185,7 @@ static int update_policy_cpu(struct cpufreq_policy *policy, unsigned int cpu,
down_write(&policy->rwsem);
policy->cpu = cpu;
+ policy->kobj_cpu = cpu;
up_write(&policy->rwsem);
return 0;
@@ -1242,10 +1243,12 @@ static int cpufreq_add_dev(struct device *dev, struct subsys_interface *sif)
* the creation of a brand new one. So we need to perform this update
* by invoking update_policy_cpu().
*/
- if (recover_policy && cpu != policy->cpu)
+ if (recover_policy && cpu != policy->cpu) {
WARN_ON(update_policy_cpu(policy, cpu, dev));
- else
+ } else {
policy->cpu = cpu;
+ policy->kobj_cpu = cpu;
+ }
cpumask_copy(policy->cpus, cpumask_of(cpu));
@@ -1424,7 +1427,7 @@ static int __cpufreq_remove_dev_prepare(struct device *dev,
CPUFREQ_NAME_LEN);
up_write(&policy->rwsem);
- if (cpu != policy->cpu) {
+ if (cpu != policy->kobj_cpu) {
sysfs_remove_link(&dev->kobj, "cpufreq");
} else if (cpus > 1) {
/* Nominate new CPU */
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index 48e37c07eb84..29ad97c34fd5 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -65,7 +65,9 @@ struct cpufreq_policy {
unsigned int shared_type; /* ACPI: ANY or ALL affected CPUs
should set cpufreq */
- unsigned int cpu; /* cpu nr of CPU managing this policy */
+ unsigned int cpu; /* cpu managing this policy, must be online */
+ unsigned int kobj_cpu; /* cpu managing sysfs files, can be offline */
+
struct clk *clk;
struct cpufreq_cpuinfo cpuinfo;/* see above */
--
2.4.0
next prev parent reply other threads:[~2015-05-18 5:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 5:13 [PATCH V5 00/14] cpufreq: Don't loose cpufreq history on CPU hotplug Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 01/14] cpufreq: Create for_each_{in}active_policy() Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 02/14] cpufreq: Don't clear cpufreq_cpu_data and policy list for inactive policies Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 03/14] cpufreq: Get rid of cpufreq_cpu_data_fallback Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 04/14] cpufreq: Don't traverse all active policies to find policy for a cpu Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 05/14] cpufreq: Manage governor usage history with 'policy->last_governor' Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 06/14] cpufreq: Mark policy->governor = NULL for inactive policies Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 07/14] cpufreq: Don't allow updating inactive policies from sysfs Viresh Kumar
2015-05-18 5:13 ` Viresh Kumar [this message]
2015-05-22 23:29 ` [PATCH V5 08/14] cpufreq: Track cpu managing sysfs kobjects separately Rafael J. Wysocki
2015-05-18 5:13 ` [PATCH V5 09/14] cpufreq: add/remove sysfs links via cpufreq_add_remove_dev_symlink() Viresh Kumar
2015-05-22 23:28 ` Rafael J. Wysocki
2015-05-23 3:41 ` Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 10/14] cpufreq: Stop migrating sysfs files on hotplug Viresh Kumar
2015-05-23 3:45 ` (unknown), Viresh Kumar
2015-05-23 4:34 ` [PATCH V6 10/14] cpufreq: Remove cpufreq_update_policy() Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 11/14] " Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 12/14] cpufreq: Initialize policy->kobj while allocating policy Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 13/14] cpufreq: Call cpufreq_policy_put_kobj() from cpufreq_policy_free() Viresh Kumar
2015-05-18 5:13 ` [PATCH V5 14/14] cpufreq: Restart governor as soon as possible Viresh Kumar
2015-05-19 0:34 ` [PATCH V5 00/14] cpufreq: Don't loose cpufreq history on CPU hotplug Rafael J. Wysocki
2015-05-19 2:27 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84aa63d8a244c2c7095ff41a2bd0013d8b95f290.1431924457.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
--cc=srivatsa@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).