From: Marc Zyngier <maz@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Christian Loehle <christian.loehle@arm.com>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Aboorva Devarajan <aboorvad@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [RFT][PATCH v1 5/5] cpuidle: menu: Avoid discarding useful information
Date: Wed, 06 Aug 2025 08:19:44 +0100 [thread overview]
Message-ID: <86bjosapdb.wl-maz@kernel.org> (raw)
In-Reply-To: <CAJZ5v0jnSwkOHuq5QjvVN7RLk=BV1Oi6Jbv1SvP5TCbAERq0yw@mail.gmail.com>
On Tue, 05 Aug 2025 19:50:21 +0100,
"Rafael J. Wysocki" <rafael@kernel.org> wrote:
[...]
> > > Any chance to try the teo governor on it to see if this problem can
> > > also be observed?
> >
> > Neither ladder nor teo have this issue. The number of broadcast timer
> > IPIs is minimal, and so is the number of interrupts delivered from the
> > backup timer. Only menu exhibits the IPI-hose behaviour on this box
> > (and only this one).
>
> Good to know, thanks!
>
> <shameless plug>Switch over to teo?</shameless plug>
Sure thing. Just start with:
git rm drivers/cpuidle/governors/menu.c
and I'll gladly switch to something else! ;-)
[...]
> The attached patch (completely untested) causes menu to insert an
> "invalid interval" value to the array of recent intervals after the
> idle state selected previously got rejected. It basically should
> prevent get_typical_interval() from returning small values if deeper
> idle states get rejected all the time.
Yup, this does the trick, thanks. When you get to post this, please
add my:
Tested-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2025-08-06 7:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 14:21 [RFT][PATCH v1 0/5] cpuidle: menu: Avoid discarding useful information when processing recent idle intervals Rafael J. Wysocki
2025-02-06 14:22 ` [RFT][PATCH v1 1/5] cpuidle: menu: Drop a redundant local variable Rafael J. Wysocki
2025-02-06 14:55 ` Christian Loehle
2025-02-06 14:24 ` [RFT][PATCH v1 2/5] cpuidle: menu: Use one loop for average and variance computations Rafael J. Wysocki
2025-02-17 13:03 ` Christian Loehle
2025-02-06 14:25 ` [RFT][PATCH v1 3/5] cpuidle: menu: Tweak threshold use in get_typical_interval() Rafael J. Wysocki
2025-02-17 13:08 ` Christian Loehle
2025-02-06 14:26 ` [RFT][PATCH v1 4/5] cpuidle: menu: Eliminate outliers on both ends of the sample set Rafael J. Wysocki
2025-02-17 13:26 ` Christian Loehle
2025-02-06 14:29 ` [RFT][PATCH v1 5/5] cpuidle: menu: Avoid discarding useful information Rafael J. Wysocki
2025-02-17 13:39 ` Christian Loehle
2025-02-17 13:47 ` Rafael J. Wysocki
2025-08-04 16:54 ` Marc Zyngier
2025-08-05 13:23 ` Rafael J. Wysocki
2025-08-05 14:41 ` Christian Loehle
2025-08-05 16:00 ` Marc Zyngier
2025-08-05 18:50 ` Rafael J. Wysocki
2025-08-06 7:19 ` Marc Zyngier [this message]
2025-08-06 12:48 ` Christian Loehle
2025-02-07 14:48 ` [RFT][PATCH v1 0/5] cpuidle: menu: Avoid discarding useful information when processing recent idle intervals Artem Bityutskiy
2025-02-07 15:24 ` Christian Loehle
2025-02-07 15:35 ` Rafael J. Wysocki
2025-02-07 15:45 ` Rafael J. Wysocki
2025-03-12 21:38 ` Doug Smythies
2025-02-10 14:15 ` Christian Loehle
2025-02-10 14:43 ` Rafael J. Wysocki
2025-02-10 14:47 ` Christian Loehle
2025-02-18 21:17 ` Christian Loehle
2025-02-19 12:06 ` Rafael J. Wysocki
2025-02-14 4:30 ` Doug Smythies
2025-02-14 22:10 ` Rafael J. Wysocki
2025-02-16 16:16 ` Doug Smythies
2025-02-24 6:27 ` Aboorva Devarajan
2025-02-24 6:38 ` Aboorva Devarajan
2025-02-24 12:35 ` Rafael J. Wysocki
2025-02-26 4:49 ` Aboorva Devarajan
2025-02-26 10:54 ` Christian Loehle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bjosapdb.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=aboorvad@linux.ibm.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=christian.loehle@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).