From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5075C2ED17A; Tue, 12 Aug 2025 10:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754993304; cv=none; b=AxehrgQtTGnnB9gC03upczhWFkR4gmlMPk8lTPWRRkmRKlX0yqzNfX2Z7IV+yB6dLGlyRLktRzKiCD7sggH1dloxGiqBsXAjbldHeojOH1MwSQ8Pub5/2HuJ6X6J1zNpUn0c763185cPKxY7PXsWWolORTTGJmge41yShqe1cFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754993304; c=relaxed/simple; bh=DAcn4+KdRlIJxAkm2lFq2UH6KxntI+jsU+V5jw07eJU=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=gDFygMel3wcmXvSpG3xvHSrNSdSBSFjNc4rBw99aFSDBMGNWkY7z1yWW33yolxkDWLyClyp1Zg0mJ1mwqyANydP3NhCADZrQz14AYLR4hrh9C1EUbrhjQCK7zYsNIiID5AnmwRl2vr1hsbbEgX6pXv+C0agnOGtKh1jS8vQokgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nxjTBXLG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nxjTBXLG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9E93C4CEF0; Tue, 12 Aug 2025 10:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754993303; bh=DAcn4+KdRlIJxAkm2lFq2UH6KxntI+jsU+V5jw07eJU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nxjTBXLGaGCKqucmDOePsdgB+WzVCR36epzi9fgyds6EOec2NjeVtkBkD/l2RUJgk n/EMB+Yh4XxsQu2G35Q47aNQcOuaopcYamPDbpL6QbH4oiE3z38XHGnaMLlPus/DQV GOdvVJKikgG7XcULz6akobffS+bfD+GnCRzJPWhGG4WCmEZeYHqWagknapWLLmLo3A KWQcCKe5jAlGQdTTY+X3xK1HmSZyytXqEnF5/+EEpGwHERmY2SlrfZignUy5DYyRnu yVBaS2s0Md1Aw+guIo3Zo1flE3QgoIs8xMKi1E+azYAMEDi9YdIP3mu6l7CE93xc0n zy615GS4lhO3g== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ulltd-006cTy-3S; Tue, 12 Aug 2025 11:08:21 +0100 Date: Tue, 12 Aug 2025 11:06:20 +0100 Message-ID: <86o6sk97mr.wl-maz@kernel.org> From: Marc Zyngier To: Yeoreum Yun Cc: catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org, oliver.upton@linux.dev, anshuman.khandual@arm.com, robh@kernel.org, james.morse@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, ry111@xry111.site, Dave.Martin@arm.com, ahmed.genidi@arm.com, kevin.brodsky@arm.com, scott@os.amperecomputing.com, mbenes@suse.cz, james.clark@linaro.org, frederic@kernel.org, rafael@kernel.org, pavel@kernel.org, ryan.roberts@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v2 6/6] KVM: arm64: initialise SCTLR2_EL1 at __kvm_host_psci_cpu_entry() In-Reply-To: References: <20250811163340.1561893-1-yeoreum.yun@arm.com> <20250811163340.1561893-7-yeoreum.yun@arm.com> <86qzxh927n.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yeoreum.yun@arm.com, catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org, oliver.upton@linux.dev, anshuman.khandual@arm.com, robh@kernel.org, james.morse@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, ry111@xry111.site, Dave.Martin@arm.com, ahmed.genidi@arm.com, kevin.brodsky@arm.com, scott@os.amperecomputing.com, mbenes@suse.cz, james.clark@linaro.org, frederic@kernel.org, rafael@kernel.org, pavel@kernel.org, ryan.roberts@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 11 Aug 2025 20:43:00 +0100, Yeoreum Yun wrote: > > Hi Marc, > > > > initialise SCTLR2_EL1 at __kvm_host_psci_cpu_entry(). > > > > Same comment, I don't think this is an acceptable commit message. > > Please ask for help if you don't feel confident writing it (I'm sure > > some of your colleagues will be happy to help). > > Okay. I'll rewrite the commit message > > > > @@ -219,6 +220,8 @@ asmlinkage void __noreturn __kvm_host_psci_cpu_entry(bool is_cpu_on) > > > release_boot_args(boot_args); > > > > > > write_sysreg_el1(INIT_SCTLR_EL1_MMU_OFF, SYS_SCTLR); > > > + if (alternative_has_cap_unlikely(ARM64_HAS_SCTLR2)) > > > + write_sysreg_el1(INIT_SCTLR2_EL1, SYS_SCTLR2); > > > write_sysreg(INIT_PSTATE_EL1, SPSR_EL2); > > > > > > __host_enter(host_ctxt); > > > > This needs to be folded into patch #1. > > > > Otherwise, there is a window of patches where the kernel will not > > survive CPU hotplug when booted in protected mode. > > Do you mean fold this patch into patch #2 where initialise > SCTLR2_ELx? Yes, sorry, I got it mixed with HCRX_EL2. Patch #2 is where it should land indeed. M. -- Without deviation from the norm, progress is not possible.