From: Thomas Gleixner <tglx@linutronix.de>
To: Ulf Hansson <ulf.hansson@linaro.org>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>,
Maulik Shah <quic_mkshah@quicinc.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v2 1/2] smp: Introduce a helper function to check for pending IPIs
Date: Mon, 27 Oct 2025 18:20:15 +0100 [thread overview]
Message-ID: <871pmow9bk.ffs@tglx> (raw)
In-Reply-To: <20251020141718.150919-2-ulf.hansson@linaro.org>
On Mon, Oct 20 2025 at 16:17, Ulf Hansson wrote:
> When governors used during cpuidle, tries to find the most optimal
When governors used during cpuidle trie to ...
Both plural and no comma.
> idlestate for a CPU or a group of CPUs, they are known to quite often fail.
idle state
> One reason for this, is that we are not taking into account whether there
...for this is, that they are not taking into account
> has been an IPI scheduled for any of the CPUs that are affected by the
> selected idlestate.
>
> To enable pending IPIs to be taken into account for cpuidle decisions,
> let's introduce a new helper function, cpus_may_have_pending_ipi().
s/let's//
> Note that, the implementation is intentionally as lightweight as possible,
> in favor of always providing the correct information.
That sentence doesn't make sense. It's a snapshot and therefore can't
provide the correct information.
> For cpuidle decisions this is good enough.
Thanks,
tglx
next prev parent reply other threads:[~2025-10-27 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 14:17 [PATCH v2 0/2] pmdomain: Improve idlestate selection for CPUs Ulf Hansson
2025-10-20 14:17 ` [PATCH v2 1/2] smp: Introduce a helper function to check for pending IPIs Ulf Hansson
2025-10-20 19:10 ` Ben Horgan
2025-10-21 10:08 ` Ulf Hansson
2025-10-27 17:15 ` Thomas Gleixner
2025-10-27 17:20 ` Thomas Gleixner [this message]
2025-10-20 14:17 ` [PATCH v2 2/2] pmdomain: Extend the genpd governor for CPUs to account for IPIs Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pmow9bk.ffs@tglx \
--to=tglx@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=quic_mkshah@quicinc.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).