Re: [PATCH v14 5/5] cpufreq: Only disable boost during cpu online when using frequency tables

Viresh Kumar
2024-06-26T03:17:56Z

On 25-06-24, 22:14, Mario Limonciello wrote:
> The earlier patches in this series do that with amd-pstate. Gautham had
> suggested a change to acpi-cpufreq for the same too.

Ahh, since I wasn't cc'd, I missed that obvious part :)

The right fix would be this then I guess:

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index a45aac17c20f..9e5060b27864 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1431,7 +1431,8 @@ static int cpufreq_online(unsigned int cpu)
}

/* Let the per-policy boost flag mirror the cpufreq_driver boost during init */
- policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy);
+ if (cpufreq_boost_enabled() && policy_has_boost_freq(policy))
+ policy->boost_enabled = true;

/*
* The initialization has succeeded and the policy is online.

--
viresh