Re: [PATCH v14 5/5] cpufreq: Only disable boost during cpu online when using frequency tables

Mario Limonciello
2024-06-26T03:14:27Z

On 6/25/2024 22:11, Viresh Kumar wrote:
> On 25-06-24, 07:31, Mario Limonciello wrote:
>> The core issue is that there are drivers that have boost functionality but
>> don't have a frequency table. As pointed out by Gautham there are also
>> drivers that have a frequency table but don't advertise boost pstates
>> (CPUFREQ_BOOST_FREQ isn't set on any frequency).
>>
>> So what happens is the driver may have choosen a policy to have boost
>> enabled but when cpufreq_online() is called it gets "marked" disabled from
>> this check introduced in f37a4d6b4a2c even though it's previously enabled.
>
> And who was setting policy->boost_enabled to true before that ? Also
> how will your patch fix the problem ? I don't see any other code
> setting it too, unless request comes from sysfs, which would work even
> now I think.
>

The earlier patches in this series do that with amd-pstate. Gautham had
suggested a change to acpi-cpufreq for the same too.

However I tested Gautham's suggestion (which is in this thread) and I
think it's the better way to do it than what I did in this v14 patch.