From: Thomas Gleixner <tglx@linutronix.de>
To: "Bae, Chang Seok" <chang.seok.bae@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
"bp@alien8.de" <bp@alien8.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 4/4] intel_idle: Add SPR support with AMX INIT-state
Date: Fri, 05 Nov 2021 18:26:27 +0100 [thread overview]
Message-ID: <8735oa4ipo.ffs@tglx> (raw)
In-Reply-To: <0B7F49C0-B850-45BC-BEC9-60DF3E2D88C5@intel.com>
On Fri, Nov 05 2021 at 16:03, Bae, Chang Seok wrote:
> On Nov 5, 2021, at 07:33, Thomas Gleixner <tglx@linutronix.de> wrote:
>> On Thu, Nov 04 2021 at 15:52, Chang S. Bae wrote:
>>> +static __cpuidle int intel_idle_tile(struct cpuidle_device *dev,
>>> + struct cpuidle_driver *drv, int index)
>>> +{
>>> + fpu_idle_fpregs();
>>
>> That's redundant because arch_cpu_idle_enter() is invoked before the
>> actual idle mechanism.
>
> I think the way this series is shaped makes confusion, sorry.
>
> Since PATCH3 and PATCH4 are in debate -- which approach should be chosen, it
> was decided to post both and let just one of them be selected. E.g., if PATCH3
> is right, then PATCH4 should be abandoned.
My bad. I should have read the cover letter before complaining.
> I think PATCH3 is better. Maybe PATCH4 should not be sent together to avoid
> such confusion.
Yes. patch 3 is way better than patch 4.
Thanks,
tglx
next prev parent reply other threads:[~2021-11-05 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211104225226.5031-1-chang.seok.bae@intel.com>
2021-11-04 22:52 ` [PATCH 4/4] intel_idle: Add SPR support with AMX INIT-state Chang S. Bae
2021-11-05 14:33 ` Thomas Gleixner
2021-11-05 16:03 ` Bae, Chang Seok
2021-11-05 17:26 ` Thomas Gleixner [this message]
2022-03-09 22:44 ` Chang S. Bae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735oa4ipo.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).