From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH v3 03/11] thermal: armada: Simplify the check of the validity bit Date: Thu, 14 Dec 2017 11:52:13 +0100 Message-ID: <877etppoo2.fsf@free-electrons.com> References: <20171214103011.24713-1-miquel.raynal@free-electrons.com> <20171214103011.24713-4-miquel.raynal@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:58145 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751173AbdLNKwZ (ORCPT ); Thu, 14 Dec 2017 05:52:25 -0500 In-Reply-To: <20171214103011.24713-4-miquel.raynal@free-electrons.com> (Miquel Raynal's message of "Thu, 14 Dec 2017 11:30:03 +0100") Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Miquel Raynal Cc: Zhang Rui , Eduardo Valentin , Rob Herring , Mark Rutland , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Catalin Marinas , Will Deacon , Thomas Petazzoni , devicetree@vger.kernel.org, Baruch Siach , linux-pm@vger.kernel.org, Antoine Tenart , Nadav Haklai , David Sniatkiwicz , linux-arm-kernel@lists.infradead.org Hi Miquel, On jeu., déc. 14 2017, Miquel Raynal wrote: > All Armada SoCs use one bit to declare if the sensor values are valid. > This bit moves across the versions of the IP. > > The method until then was to do both a shift and compare with an useless > flag of "0x1". It is clearer and quicker to directly save the value that > must be ANDed instead of the bit position and do a single bitwise AND > operation. > > Signed-off-by: Miquel Raynal Reviewed-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/thermal/armada_thermal.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c > index 6c4af2622d4f..26698f2d3ca7 100644 > --- a/drivers/thermal/armada_thermal.c > +++ b/drivers/thermal/armada_thermal.c > @@ -24,8 +24,6 @@ > #include > #include > > -#define THERMAL_VALID_MASK 0x1 > - > /* Thermal Manager Control and Status Register */ > #define PMU_TDC0_SW_RST_MASK (0x1 << 1) > #define PMU_TM_DISABLE_OFFS 0 > @@ -67,7 +65,7 @@ struct armada_thermal_data { > /* Register shift and mask to access the sensor temperature */ > unsigned int temp_shift; > unsigned int temp_mask; > - unsigned int is_valid_shift; > + unsigned int is_valid_bit; > }; > > static void armadaxp_init_sensor(struct platform_device *pdev, > @@ -151,7 +149,7 @@ static bool armada_is_valid(struct armada_thermal_priv *priv) > { > unsigned long reg = readl_relaxed(priv->sensor); > > - return (reg >> priv->data->is_valid_shift) & THERMAL_VALID_MASK; > + return reg & priv->data->is_valid_bit; > } > > static int armada_get_temp(struct thermal_zone_device *thermal, > @@ -199,7 +197,7 @@ static const struct armada_thermal_data armadaxp_data = { > static const struct armada_thermal_data armada370_data = { > .is_valid = armada_is_valid, > .init_sensor = armada370_init_sensor, > - .is_valid_shift = 9, > + .is_valid_bit = BIT(9), > .temp_shift = 10, > .temp_mask = 0x1ff, > .coef_b = 3153000000UL, > @@ -210,7 +208,7 @@ static const struct armada_thermal_data armada370_data = { > static const struct armada_thermal_data armada375_data = { > .is_valid = armada_is_valid, > .init_sensor = armada375_init_sensor, > - .is_valid_shift = 10, > + .is_valid_bit = BIT(10), > .temp_shift = 0, > .temp_mask = 0x1ff, > .coef_b = 3171900000UL, > @@ -221,7 +219,7 @@ static const struct armada_thermal_data armada375_data = { > static const struct armada_thermal_data armada380_data = { > .is_valid = armada_is_valid, > .init_sensor = armada380_init_sensor, > - .is_valid_shift = 10, > + .is_valid_bit = BIT(10), > .temp_shift = 0, > .temp_mask = 0x3ff, > .coef_b = 1172499100UL, > -- > 2.11.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com