From: Takashi Iwai <tiwai@suse.de>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
laurent.pinchart@ideasonboard.com,
"Jacek Lawrynowicz" <jacek.lawrynowicz@linux.intel.com>,
"Stanislaw Gruszka" <stanislaw.gruszka@linux.intel.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Paul Elder" <paul.elder@ideasonboard.com>,
"Alex Elder" <elder@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Mark Brown" <broonie@kernel.org>
Subject: Re: [PATCH 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage
Date: Tue, 09 Jan 2024 17:50:06 +0100 [thread overview]
Message-ID: <878r4yqwn5.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240109133657.111258-1-sakari.ailus@linux.intel.com>
On Tue, 09 Jan 2024 14:36:57 +0100,
Sakari Ailus wrote:
>
> There are two ways to opportunistically increment a device's runtime PM
> usage count, calling either pm_runtime_get_if_active() or
> pm_runtime_get_if_in_use(). The former has an argument to tell whether to
> ignore the usage count or not, and the latter simply calls the former with
> ign_usage_count set to false. The other users that want to ignore the
> usage_count will have to explitly set that argument to true which is a bit
> cumbersome.
>
> To make this function more practical to use, remove the ign_usage_count
> argument from the function. The main implementation is renamed as
> __pm_runtime_get_conditional().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> Documentation/power/runtime_pm.rst | 5 ++--
> drivers/accel/ivpu/ivpu_pm.c | 2 +-
> drivers/base/power/runtime.c | 9 ++++---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +-
> drivers/gpu/drm/xe/xe_pm.c | 2 +-
> drivers/media/i2c/ccs/ccs-core.c | 2 +-
> drivers/media/i2c/ov64a40.c | 2 +-
> drivers/media/i2c/thp7312.c | 2 +-
> drivers/net/ipa/ipa_smp2p.c | 2 +-
> drivers/pci/pci.c | 2 +-
> include/linux/pm_runtime.h | 32 +++++++++++++++++++++----
> sound/hda/hdac_device.c | 2 +-
For sound/*,
Acked-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
next prev parent reply other threads:[~2024-01-09 16:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 13:36 [PATCH 0/2] Small runtime PM API changes Sakari Ailus
2024-01-09 13:36 ` [PATCH 2/2] pm: runtime: Add pm_runtime_put_autosuspend() replacement Sakari Ailus
2024-01-09 16:40 ` Laurent Pinchart
2024-01-09 18:56 ` Sakari Ailus
2024-01-09 13:36 ` [PATCH 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage Sakari Ailus
2024-01-09 16:28 ` Alex Elder
2024-01-09 16:37 ` Laurent Pinchart
2024-01-09 16:50 ` Takashi Iwai [this message]
2024-01-09 17:23 ` Jacek Lawrynowicz
2024-01-09 17:35 ` Rodrigo Vivi
2024-01-09 19:08 ` Sakari Ailus
2024-01-10 11:58 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r4yqwn5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=airlied@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-pm@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=paul.elder@ideasonboard.com \
--cc=perex@perex.cz \
--cc=rafael@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox