From: Kevin Hilman <khilman@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-arm-kernel@lists.infradead.org, rjw@sisk.pl,
kgene.kim@samsung.com, magnus.damm@gmail.com,
ben-linux@fluff.org, linux-pm@vger.kernel.org, nsekhar@ti.com,
linus.walleij@linaro.org, swarren@wwwdotorg.org,
nicolas.ferre@atmel.com, daniel.lezcano@linaro.org,
kyungmin.park@samsung.com, horms@verge.net.au,
srinidhi.kasagar@stericsson.com, kernel@pengutronix.de,
shawn.guo@linaro.org, plagnioj@jcrosoft.com, linux@maxim.org.za
Subject: Re: [PATCH 4/8] ARM: OMAP: move cpuidle drivers to drivers/cpuidle/
Date: Thu, 27 Jun 2013 10:25:14 -0700 [thread overview]
Message-ID: <878v1vqxdx.fsf@linaro.org> (raw)
In-Reply-To: <20130627080653.GH5523@atomide.com> (Tony Lindgren's message of "Thu, 27 Jun 2013 01:06:54 -0700")
Tony Lindgren <tony@atomide.com> writes:
> * Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> [130626 12:25]:
>> While at it:
>> - remove file path from comment
>> - fix whitespace issues
>>
>> Compile tested only.
> ...
>
>> --- /dev/null
>> +++ b/drivers/cpuidle/cpuidle-omap34xx.c
>> @@ -0,0 +1,342 @@
>> +/*
>> + * OMAP3 CPU IDLE Routines
>> + *
>> + * Copyright (C) 2008 Texas Instruments, Inc.
>> + * Rajendra Nayak <rnayak@ti.com>
>> + *
>> + * Copyright (C) 2007 Texas Instruments, Inc.
>> + * Karthik Dasu <karthik-dp@ti.com>
>> + *
>> + * Copyright (C) 2006 Nokia Corporation
>> + * Tony Lindgren <tony@atomide.com>
>> + *
>> + * Copyright (C) 2005 Texas Instruments, Inc.
>> + * Richard Woodruff <r-woodruff2@ti.com>
>> + *
>> + * Based on pm.c for omap2
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +#include <linux/sched.h>
>> +#include <linux/cpuidle.h>
>> +#include <linux/export.h>
>> +#include <linux/cpu_pm.h>
>> +#include <asm/cpuidle.h>
>> +
>> +#include "../../arch/arm/mach-omap2/powerdomain.h"
>> +#include "../../arch/arm/mach-omap2/clockdomain.h"
>> +
>> +#include "../../arch/arm/mach-omap2/pm.h"
>> +#include "../../arch/arm/mach-omap2/control.h"
>> +#include "../../arch/arm/mach-omap2/common.h"
>
> Do we really want to do includes like this from drivers?
> Presumably these will go away with DT, but still.
>
> Kevin, any comments?
NACK
We need proper interfaces to platform-specific code before moving.
Kevin
next prev parent reply other threads:[~2013-06-27 17:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 10:15 [PATCH 0/8] ARM: move cpuidle drivers to drivers/cpuidle/ Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 1/8] ARM: at91: move cpuidle driver " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 2/8] ARM: davinci: " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 3/8] ARM: imx: move cpuidle drivers " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 4/8] ARM: OMAP: " Bartlomiej Zolnierkiewicz
2013-06-27 8:06 ` Tony Lindgren
2013-06-27 17:25 ` Kevin Hilman [this message]
2013-06-27 15:36 ` Santosh Shilimkar
2013-06-26 10:15 ` [PATCH 5/8] ARM: S3C64XX: move cpuidle driver " Bartlomiej Zolnierkiewicz
2013-07-22 3:33 ` Kukjin Kim
2013-06-26 10:15 ` [PATCH 6/8] ARM: shmobile: " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 7/8] ARM: tegra: move cpuidle drivers " Bartlomiej Zolnierkiewicz
2013-06-26 18:24 ` Stephen Warren
2013-06-26 10:15 ` [PATCH 8/8] ARM: ux500: " Bartlomiej Zolnierkiewicz
2013-06-26 20:42 ` Linus Walleij
2013-06-26 21:28 ` Arnd Bergmann
2013-06-26 10:59 ` [PATCH 0/8] ARM: " Daniel Lezcano
2013-06-26 12:22 ` Bartlomiej Zolnierkiewicz
2013-06-26 13:05 ` Daniel Lezcano
2013-06-26 14:40 ` Bartlomiej Zolnierkiewicz
2013-06-26 16:57 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v1vqxdx.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=daniel.lezcano@linaro.org \
--cc=horms@verge.net.au \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=magnus.damm@gmail.com \
--cc=nicolas.ferre@atmel.com \
--cc=nsekhar@ti.com \
--cc=plagnioj@jcrosoft.com \
--cc=rjw@sisk.pl \
--cc=shawn.guo@linaro.org \
--cc=srinidhi.kasagar@stericsson.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).