From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH v2 15/21] ARM: pxa: magician: Fix PWM backlight regulator Date: Thu, 20 Aug 2015 21:58:25 +0200 Message-ID: <87d1yh68bi.fsf@belgarion.home> References: <55D25A4A.4070409@tul.cz> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from smtp12.smtpout.orange.fr ([80.12.242.134]:19682 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbbHTUCd (ORCPT ); Thu, 20 Aug 2015 16:02:33 -0400 In-Reply-To: <55D25A4A.4070409@tul.cz> (Petr Cvek's message of "Tue, 18 Aug 2015 00:03:54 +0200") Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Petr Cvek Cc: philipp.zabel@gmail.com, daniel@zonque.org, haojian.zhuang@gmail.com, sameo@linux.intel.com, lee.jones@linaro.org, cooloney@gmail.com, rpurdie@rpsys.net, j.anaszewski@samsung.com, linux@arm.linux.org.uk, sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Petr Cvek writes: > Fix PWM backlight regulator. It is requested from pwm_backlight_probe(). Even if I know why you have to fix it, somebody else reading your commit message should understand why this fix is need. You need to explain why it is needed, ie. what happens without it, and therefore what justifies this patch. Cheers. -- Robert PS: For inspiration, look at Thierry's commit 902e6a0c7eba.