From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] ath10k: Drop WARN_ON()s that always trigger during system resume Date: Mon, 29 Apr 2019 17:12:39 +0300 Message-ID: <87ef5ksxwo.fsf@kamboji.qca.qualcomm.com> References: <2884043.Jv1Mn93hE8@aspire.rjw.lan> <20190403195718.GA74723@google.com> <87o94tutdz.fsf@kamboji.qca.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Claire Chang's message of "Mon, 29 Apr 2019 18:41:50 +0800") Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Claire Chang Cc: "Rafael J. Wysocki" , Brian Norris , "Rafael J. Wysocki" , Sriram R , Linux PM , Pradeep Kumar Chitrapu , "open list:NETWORKING DRIVERS (WIRELESS)" , ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Srinivas Pandruvada , Todd Brandt List-Id: linux-pm@vger.kernel.org Claire Chang writes: > Tested-by: Claire Chang > >> Still, I'm quite sure that the WARN_ON()s trigger during system resume >> regardless of the hw/fw combination. > > Also see this on sido: > > [ 4.925278] ath10k_sdio mmc1:0001:1: qca6174 hw3.2 sdio target > 0x05030000 chip_id 0x00000000 sub 0000:0000 > [ 4.935721] ath10k_sdio mmc1:0001:1: kconfig debug 1 debugfs 1 > tracing 1 dfs 0 testmode 1 > [ 4.948750] ath10k_sdio mmc1:0001:1: firmware ver > WLAN.RMH.4.4.1-00007-QCARMSWP-1 api 6 features wowlan,ignore-otp crc32 > b98adaf8 > [ 5.132728] ath10k_sdio mmc1:0001:1: board_file api 2 bmi_id 0:4 > crc32 6364cfcc Great, thanks. I added your Tested-by as well. -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E34C43219 for ; Mon, 29 Apr 2019 14:12:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A50B20652 for ; Mon, 29 Apr 2019 14:12:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="LgQ7oG3a"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cAqhi9CY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728240AbfD2OMq (ORCPT ); Mon, 29 Apr 2019 10:12:46 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34586 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728196AbfD2OMq (ORCPT ); Mon, 29 Apr 2019 10:12:46 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5F41C608D4; Mon, 29 Apr 2019 14:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556547165; bh=1YZh4rF0kC09u7WTScxlAdfqd54VJi90HDJpSFG+7ok=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LgQ7oG3a7aMS2P6gFSOq//qIm4Y6+BciY5Ss2yC6sW86P94t7y4jmF+XvgOnOeIWA LzvjzHpbrTWsmPBphGPr0oCk2WZfcWB/L77o0UiQG+yzyFl+VOO8KQ3rFts2SS0Pb/ wh9qPCUL9mPCWZr8lx7x7MNEAgzWJKT0QBwDl7yo= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id EA37060128; Mon, 29 Apr 2019 14:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556547164; bh=1YZh4rF0kC09u7WTScxlAdfqd54VJi90HDJpSFG+7ok=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cAqhi9CYDKkZOBxA+SjQlQNFW46U5JNEPqdn2l2ODhmMoOUm+6R6xvBr7riMX5Mba APcNs7VLVnkaVy7XHUL08RmiS6J0B72v35YHVtuyOW6SjJCdDCajyk5WQd7xJUCAiJ FzlBzv2rV7iqpsnfXvOkRaxWw1LQwfBHS5X6jaas= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EA37060128 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Claire Chang Cc: "Rafael J. Wysocki" , Brian Norris , "Rafael J. Wysocki" , Sriram R , Linux PM , Pradeep Kumar Chitrapu , "open list\:NETWORKING DRIVERS \(WIRELESS\)" , ath10k@lists.infradead.org, Srinivas Pandruvada , Todd Brandt Subject: Re: [PATCH] ath10k: Drop WARN_ON()s that always trigger during system resume References: <2884043.Jv1Mn93hE8@aspire.rjw.lan> <20190403195718.GA74723@google.com> <87o94tutdz.fsf@kamboji.qca.qualcomm.com> Date: Mon, 29 Apr 2019 17:12:39 +0300 In-Reply-To: (Claire Chang's message of "Mon, 29 Apr 2019 18:41:50 +0800") Message-ID: <87ef5ksxwo.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20190429141239.8p1dX5NnBg8BRGhXNmgrxV1phZG0eUJIHfDbFgcJQVI@z> Claire Chang writes: > Tested-by: Claire Chang > >> Still, I'm quite sure that the WARN_ON()s trigger during system resume >> regardless of the hw/fw combination. > > Also see this on sido: > > [ 4.925278] ath10k_sdio mmc1:0001:1: qca6174 hw3.2 sdio target > 0x05030000 chip_id 0x00000000 sub 0000:0000 > [ 4.935721] ath10k_sdio mmc1:0001:1: kconfig debug 1 debugfs 1 > tracing 1 dfs 0 testmode 1 > [ 4.948750] ath10k_sdio mmc1:0001:1: firmware ver > WLAN.RMH.4.4.1-00007-QCARMSWP-1 api 6 features wowlan,ignore-otp crc32 > b98adaf8 > [ 5.132728] ath10k_sdio mmc1:0001:1: board_file api 2 bmi_id 0:4 > crc32 6364cfcc Great, thanks. I added your Tested-by as well. -- Kalle Valo