From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 0/2] thermal: rcar-thermal: minor fixes Date: Sun, 02 Mar 2014 15:52:04 -0800 (PST) Message-ID: <87fvn0xioy.wl%kuninori.morimoto.gx@gmail.com> References: <1393593004-16285-1-git-send-email-ptitiano@baylibre.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:45109 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753669AbaCBXwG (ORCPT ); Sun, 2 Mar 2014 18:52:06 -0500 In-Reply-To: <1393593004-16285-1-git-send-email-ptitiano@baylibre.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Patrick Titiano Cc: magnus.damm@gmail.com, kuninori.morimoto.gx@renesas.com, eduardo.valentin@ti.com, bcousson@baylibre.com, linux-pm@vger.kernel.org, linux-sh@vger.kernel.org Hi > Here are 2 minor updates to the rcar-thermal driver. > > First patch removes an unecessary mask applied in a if statement. > Because the same mask was already applied in the preceding statement, > the second one can be removed. > > Second patch avoids updating the thermal zone in case an IRQ was triggered but > the temperature didn't effectively change. > Note this is not a driver issue. > Below is a captured debug trace illustrating the purpose of this patch: > out of 8 thermal zone updates, only 2 are actually necessary. > > [ 41.120000] rcar_thermal_work(): cctemp=25000 > [ 41.120000] rcar_thermal_work(): new_ctemp=30000 > [ 41.120000] rcar_thermal_work(): temp is now 30000C, update thermal zone > [ 58.990000] rcar_thermal_work(): cctemp=30000 > [ 58.990000] rcar_thermal_work(): nctemp=30000 > [ 58.990000] rcar_thermal_work(): same temp, do not update thermal zone > [ 59.290000] rcar_thermal_work(): cctemp=30000 > [ 59.290000] rcar_thermal_work(): nctemp=30000 > [ 59.290000] rcar_thermal_work(): same temp, do not update thermal zone > [ 59.590000] rcar_thermal_work(): cctemp=30000 > [ 59.590000] rcar_thermal_work(): nctemp=30000 > [ 59.590000] rcar_thermal_work(): same temp, do not update thermal zone > [ 59.890000] rcar_thermal_work(): cctemp=30000 > [ 59.890000] rcar_thermal_work(): nctemp=30000 > [ 59.890000] rcar_thermal_work(): same temp, do not update thermal zone > [ 60.190000] rcar_thermal_work(): cctemp=30000 > [ 60.190000] rcar_thermal_work(): nctemp=30000 > [ 60.190000] rcar_thermal_work(): same temp, do not update thermal zone > [ 60.490000] rcar_thermal_work(): cctemp=30000 > [ 60.490000] rcar_thermal_work(): nctemp=30000 > [ 60.490000] rcar_thermal_work(): same temp, do not update thermal zone > [ 60.790000] rcar_thermal_work(): cctemp=30000 > [ 60.790000] rcar_thermal_work(): nctemp=35000 > [ 60.790000] rcar_thermal_work(): temp is now 35000C, update thermal zone > > I suspect this may be due to sensor sampling accuracy / fluctuation, > but no formal proof. > > Patrick Titiano (2): > thermal: rcar-thermal: fix same mask applied twice > thermal: rcar-thermal: update thermal zone only when temperature > changes > > drivers/thermal/rcar_thermal.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) For all patches Acked-by: Kuninori Morimoto