From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM Date: Thu, 27 Feb 2014 16:44:08 -0800 (PST) Message-ID: <87fvn4yskv.wl%kuninori.morimoto.gx@gmail.com> References: <1390688954-4940-1-git-send-email-richard@nod.at> <1393484282.2637.17.camel@rzhang1-mobl4> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1393484282.2637.17.camel@rzhang1-mobl4> Sender: linux-kernel-owner@vger.kernel.org To: Zhang Rui Cc: Richard Weinberger , eduardo.valentin@ti.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, horms@verge.net.au, laurent.pinchart+renesas@ideasonboard.com List-Id: linux-pm@vger.kernel.org Hi Zhang > On Sat, 2014-01-25 at 23:29 +0100, Richard Weinberger wrote: > > Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST) > > broke build on archs wihout io memory. > > > > On archs like S390 or um this driver cannot build nor work. > > Make it depend on HAS_IOMEM to bypass build failures. > > > > drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource' > > drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource' > > > > Signed-off-by: Richard Weinberger > > Kuninori, > > are you okay with this patch? (snip) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index 35c0664..88efa8f 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -136,6 +136,7 @@ config SPEAR_THERMAL > > config RCAR_THERMAL > > tristate "Renesas R-Car thermal driver" > > depends on ARCH_SHMOBILE || COMPILE_TEST > > + depends on HAS_IO_MEM > > help > > Enable this to plug the R-Car thermal sensor driver into the Linux > > thermal framework. I guess - HAS_IO_MEM + HAS_IOMEM ${LINUX}/lib/Makefile say obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o