Re: runtime PM: common hooks for static and runtime PM

Alan Stern
2010-03-18T14:13:21Z

On Wed, 17 Mar 2010, Kevin Hilman wrote:

> >> > @@ -729,6 +729,26 @@ static void platform_pm_complete(struct device *dev)
> >> >
> >> > #ifdef CONFIG_SUSPEND
> >>
> >> This probably should be CONFIG_SLEEP.
> >
> > CONFIG_PM_SLEEP to be precise.
>
> That #ifdef was not part of my patch, it was just part of the diff
> context. I'm just adding these new hooks inside the same ifdef that
> the platform_bus system PM hooks are defined.
>
> Are you suggesting I also fixup the #ifdef in that code?

That would be a good idea. It can be done in a separate patch.

The point is that CONFIG_SUSPEND is defined only when you enable
standby or suspend-to-RAM, and CONFIG_HIBERNATION is defined only when
you enable suspend-to-disk, whereas CONFIG_SLEEP is defined when either
of the others is.

Alan Stern