Re: [PATCH] Driver Core: Add platform device arch data V3

Magnus Damm
2009-06-24T11:50:18Z

On Fri, Jun 19, 2009 at 1:21 AM, Kevin
Hilman<khilman@deeprootsystems.com> wrote:
> Magnus Damm <magnus.damm@gmail.com> writes:
>
>> From: Magnus Damm <damm@igel.co.jp>
>>
>> Allow architecture specific data in struct platform_device V3.
>>
>> With this patch struct pdev_archdata is added to struct
>> platform_device, similar to struct dev_archdata in found in
>> struct device. Useful for architecture code that needs to
>> keep extra data associated with each platform device.
>>
>> Struct pdev_archdata is different from dev.platform_data, the
>> convention is that dev.platform_data points to driver-specific
>> data. It may or may not be required by the driver. The format
>> of this depends on driver but is the same across architectures.
>>
>> The structure pdev_archdata is a place for architecture specific
>> data. This data is handled by architecture specific code (for
>> example runtime PM), and since it is architecture specific it
>> should _never_ be touched by device driver code. Exactly like
>> struct dev_archdata but for platform devices.
>>
>> Signed-off-by: Magnus Damm <damm@igel.co.jp>
>
> Since there is no 'Feature-desired-by:' tag, I'll addd
>
> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
>
> For PM on ARM in general, and OMAP in particular we definitely need a
> generic way to handle arch-specific data per platform_device.

Thanks, Kevin! So ARM in general or at least OMAP wants this, and so
does SuperH.

Rafael, you kindly gave feedback on earlier versions, are you ok with
this version?

Cheers,

/ magnus