From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH v2 6/7] cpufreq: Add DVFS support for Armada 37xx Date: Wed, 13 Dec 2017 17:45:05 +0100 Message-ID: <87vahapofi.fsf@free-electrons.com> References: <20171207135616.23670-1-gregory.clement@free-electrons.com> <20171207135616.23670-7-gregory.clement@free-electrons.com> <20171212072426.GK25177@vireshk-i7> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:40686 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753586AbdLMQpQ (ORCPT ); Wed, 13 Dec 2017 11:45:16 -0500 In-Reply-To: <20171212072426.GK25177@vireshk-i7> (Viresh Kumar's message of "Tue, 12 Dec 2017 12:54:26 +0530") Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , devicetree@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Antoine Tenart , =?utf-8?Q?Miqu=C3=A8l?= Raynal , Nadav Haklai , Victor Gu , Marcin Wojtas , Wilson Ding , Hua Jing , Neta Zur Hershkovits , Evan Wang , Andre Heider Hi Viresh, On mar., déc. 12 2017, Viresh Kumar wrote: > On 07-12-17, 14:56, Gregory CLEMENT wrote: >> +/* Power management in North Bridge register set */ >> +#define ARMADA_37XX_NB_L0L1 0x18 >> +#define ARMADA_37XX_NB_L2L3 0x1C >> +#define ARMADA_37XX_NB_TBG_DIV_OFF 13 >> +#define ARMADA_37XX_NB_TBG_DIV_MASK 0x7 >> +#define ARMADA_37XX_NB_CLK_SEL_OFF 11 >> +#define ARMADA_37XX_NB_CLK_SEL_MASK 0x1 >> +#define ARMADA_37XX_NB_CLK_SEL_TBG 0x1 >> +#define ARMADA_37XX_NB_TBG_SEL_OFF 9 >> +#define ARMADA_37XX_NB_TBG_SEL_MASK 0x3 >> +#define ARMADA_37XX_NB_VDD_SEL_OFF 6 >> +#define ARMADA_37XX_NB_VDD_SEL_MASK 0x3 >> +#define ARMADA_37XX_NB_CONFIG_SHIFT 16 >> +#define ARMADA_37XX_NB_DYN_MOD 0x24 >> +#define ARMADA_37XX_NB_CLK_SEL_EN BIT(26) >> +#define ARMADA_37XX_NB_TBG_EN BIT(28) >> +#define ARMADA_37XX_NB_DIV_EN BIT(29) >> +#define ARMADA_37XX_NB_VDD_EN BIT(30) >> +#define ARMADA_37XX_NB_DFS_EN BIT(31) >> +#define ARMADA_37XX_NB_CPU_LOAD 0x30 >> +#define ARMADA_37XX_NB_CPU_LOAD_MASK 0x3 >> +#define ARMADA_37XX_DVFS_LOAD_0 0 >> +#define ARMADA_37XX_DVFS_LOAD_1 1 >> +#define ARMADA_37XX_DVFS_LOAD_2 2 >> +#define ARMADA_37XX_DVFS_LOAD_3 3 > > I thought you agreed to using space instead of tab after #define ? Me too! Actually I did it, and I don't know what happened with this patch. However it will be part of the next version and I will double check it. > > Looks fine otherwise. You can add below after fixing above tab/space thing: > > Acked-by: Viresh Kumar Thanks, Gregory > > -- > viresh -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com