From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-pm-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C78E0ECAAD1
	for <linux-pm@archiver.kernel.org>; Thu,  1 Sep 2022 14:55:42 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234328AbiIAOzl (ORCPT <rfc822;linux-pm@archiver.kernel.org>);
        Thu, 1 Sep 2022 10:55:41 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39038 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234488AbiIAOzf (ORCPT
        <rfc822;linux-pm@vger.kernel.org>); Thu, 1 Sep 2022 10:55:35 -0400
Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25C0737F96
        for <linux-pm@vger.kernel.org>; Thu,  1 Sep 2022 07:55:31 -0700 (PDT)
Received: by mail-wm1-x332.google.com with SMTP id h1so9165083wmd.3
        for <linux-pm@vger.kernel.org>; Thu, 01 Sep 2022 07:55:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=bytedance-com.20210112.gappssmtp.com; s=20210112;
        h=mime-version:message-id:date:user-agent:references:in-reply-to
         :subject:cc:to:from:from:to:cc;
        bh=Qm7z+n9v24oP6zpPgqQul26KMHD50paO2Y9IVMFiRhQ=;
        b=dd+Zsnugr8tFEBhl38/jbIsJ0BodE3L0d6on+MXP5Gp/QC92iSbt90u+oraLzgx0iP
         chX8O52Z11VUfusvEYE06r25mQwVDyBw/hwgmJ8scDQb6qlWx8H6L1n+h/IgpHkisROE
         TvBY9xGjVEDYq8aipQJ54wC0EyalZ3OWVNYKeqQepIPeX1FT+0zLOIAokKToNo2u5qcq
         PT6NS8ANAUJ1QpZ3tSoBW+gIIU2QUUIOWzG1G56x+KDOddNrzJiyiqtnRqOVnfROLXph
         YkbuF6dazdnIRYZe6gjQhJX5hi3YiTYVDswYAlYr1KZsuR0QKzH505dJHQvZJPyTXjng
         fvOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=mime-version:message-id:date:user-agent:references:in-reply-to
         :subject:cc:to:from:x-gm-message-state:from:to:cc;
        bh=Qm7z+n9v24oP6zpPgqQul26KMHD50paO2Y9IVMFiRhQ=;
        b=JlrbhnNkjMIVVTSDomr3rzjDHbhBm7IXpkpyVAfi6Kv6OlTiWGa/Ra8T/v8RgUOWiQ
         sTctHHiGcQ0VUAVMIutH2SvpR3WnfeycKi8MdG9G6thp4tuORfp/uQjuovfxYQ5QoHiI
         N7Dn+my17sXaru98cGdmc9zseOItXLXyoWdDbj8gXN3zqFP5RYIgAbRvndmEU7quib/c
         sPu/BpDU5O7zuLg9V4k3sOxz0E0mfiswcTULMMIhd5Xdu3KlFRB2p6YFm+vfE/vUuQ8X
         jiVI67Kx0ez68yPZIa1Jtj+iybls5Ma5BnuJrqalE0OcZUkrIrlzbMJgbmwKO00f6gTg
         kVbQ==
X-Gm-Message-State: ACgBeo3WL64GkSnkHdQKokmfAaIipG9pfTjo42u3gdfd9piHK/frlEsq
        A3J1jg2VBZzAjE0Tood2Qij07A==
X-Google-Smtp-Source: AA6agR44HpRoT6gpp2fWtRApwrHYPW65PMjZqe5oGuSrovokUtg4BrlR9Cjq87AC1M2f/BCYYIqWag==
X-Received: by 2002:a05:600c:35d0:b0:3a8:3f16:2c38 with SMTP id r16-20020a05600c35d000b003a83f162c38mr5695050wmq.162.1662044129389;
        Thu, 01 Sep 2022 07:55:29 -0700 (PDT)
Received: from localhost ([95.148.15.66])
        by smtp.gmail.com with ESMTPSA id e20-20020a05600c4e5400b003a5bd5ea215sm5559533wmq.37.2022.09.01.07.55.28
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 01 Sep 2022 07:55:28 -0700 (PDT)
From:   Punit Agrawal <punit.agrawal@bytedance.com>
To:     Perry Yuan <Perry.Yuan@amd.com>
Cc:     <rafael.j.wysocki@intel.com>, <ray.huang@amd.com>,
        <viresh.kumar@linaro.org>, <Deepak.Sharma@amd.com>,
        <Mario.Limonciello@amd.com>, <Nathan.Fontenot@amd.com>,
        <Alexander.Deucher@amd.com>, <Jinzhou.Su@amd.com>,
        <Shimmer.Huang@amd.com>, <Xiaojian.Du@amd.com>, <Li.Meng@amd.com>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and
 duplicated headers declaration
In-Reply-To: <20220901062339.2357552-1-Perry.Yuan@amd.com> (Perry Yuan's
        message of "Thu, 1 Sep 2022 14:23:39 +0800")
References: <20220901062339.2357552-1-Perry.Yuan@amd.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Date:   Thu, 01 Sep 2022 15:55:27 +0100
Message-ID: <87y1v3cffk.fsf@stealth>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-pm.vger.kernel.org>
X-Mailing-List: linux-pm@vger.kernel.org

Hi Perry,

Perry Yuan <Perry.Yuan@amd.com> writes:

> Cleanup the headers declaration which are not used
> actually and some duplicated declaration which is declarated in some
> other headers already, it will help to simplify the header part.
>
> Reviewed-by: Huang Rui <ray.huang@amd.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 9ac75c1cde9c..9cf7bc162e7c 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -31,19 +31,15 @@
>  #include <linux/compiler.h>
>  #include <linux/dmi.h>
>  #include <linux/slab.h>
> -#include <linux/acpi.h>
>  #include <linux/io.h>
>  #include <linux/delay.h>
>  #include <linux/uaccess.h>
>  #include <linux/static_call.h>
>  
> -#include <acpi/processor.h>
>  #include <acpi/cppc_acpi.h>
>  
>  #include <asm/msr.h>
>  #include <asm/processor.h>
> -#include <asm/cpufeature.h>
> -#include <asm/cpu_device_id.h>
>  #include "amd-pstate-trace.h"
>  
>  #define AMD_PSTATE_TRANSITION_LATENCY	0x20000

The patch has the same issue as mentioned in the previous version.

Please don't remove any header includes whose definitions are directly
used in amd-pstate.c. Look at example from my previous comment.