From: Chris Ball <cjb@laptop.org>
To: Ulf Hansson <ulf.hansson@stericsson.com>
Cc: Chuanxiao Dong <chuanxiao.dong@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-pm@lists.linux-foundation.org"
<linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH V4]mmc: remove MMC bus legacy suspend/resume method
Date: Wed, 11 Apr 2012 10:44:47 -0400 [thread overview]
Message-ID: <87y5q2s4yo.fsf@laptop.org> (raw)
In-Reply-To: <4F858A25.20302@stericsson.com> (Ulf Hansson's message of "Wed, 11 Apr 2012 15:41:57 +0200")
Hi,
On Wed, Apr 11 2012, Ulf Hansson wrote:
> On 04/11/2012 01:54 PM, Chuanxiao Dong wrote:
>> MMC bus is using legacy suspend/resume method, which is not compatible if
>> runtime pm callbacks are used. In this scenario, MMC bus suspend/resume
>> callbacks cannot be called when system entering S3. So change to use the new
>> defined dev_pm_ops for system sleeping mode
>>
>> Signed-off-by: Chuanxiao Dong<chuanxiao.dong@intel.com>
>> ---
>> Changes in v2:
>> use SET_SYSTEM_SLEEP_PM_OPS to define sleep callbacks as Rafael
>> suggested
>>
>> Changes in v3:
>> remove NULL pointer define for runtime callbacks when PM_RUNTIME is not
>> selected, as Ulf Hansson suggested
>>
>> Changes in v4:
>> fix the warning when disable CONFIG_PM_RUNTIME
>>
>
> Looks good to me! Acked-by: Ulf Hansson <ulf.hansson@stericsson.com>
Thanks! Pushed to mmc-next for 3.4.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-04-11 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 11:54 [PATCH V4]mmc: remove MMC bus legacy suspend/resume method Chuanxiao Dong
2012-04-11 13:41 ` Ulf Hansson
2012-04-11 14:44 ` Chris Ball [this message]
2012-04-16 5:47 ` Hebbar, Gururaja
2012-04-16 5:46 ` Hebbar, Gururaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5q2s4yo.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=chuanxiao.dong@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=ulf.hansson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox