* [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() @ 2017-06-30 7:22 ` Gustavo A. R. Silva 2017-06-30 8:02 ` Chanwoo Choi 2017-07-03 11:35 ` Jon Hunter 0 siblings, 2 replies; 9+ messages in thread From: Gustavo A. R. Silva @ 2017-06-30 7:22 UTC (permalink / raw) To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Thierry Reding, Jonathan Hunter Cc: linux-pm, linux-tegra, linux-kernel, Gustavo A. R. Silva Print and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/devfreq/tegra-devfreq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c index 214fff9..ae71215 100644 --- a/drivers/devfreq/tegra-devfreq.c +++ b/drivers/devfreq/tegra-devfreq.c @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - dev_err(&pdev->dev, "Failed to get IRQ\n"); - return -ENODEV; + if (irq < 0) { + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); + return irq; } platform_set_drvdata(pdev, tegra); -- 2.5.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() 2017-06-30 7:22 ` [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() Gustavo A. R. Silva @ 2017-06-30 8:02 ` Chanwoo Choi [not found] ` <5956058A.3090304-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2017-07-03 11:35 ` Jon Hunter 1 sibling, 1 reply; 9+ messages in thread From: Chanwoo Choi @ 2017-06-30 8:02 UTC (permalink / raw) To: Gustavo A. R. Silva, MyungJoo Ham, Kyungmin Park, Thierry Reding, Jonathan Hunter Cc: linux-pm, linux-tegra, linux-kernel Hi, On 2017년 06월 30일 16:22, Gustavo A. R. Silva wrote: > Print and propagate the return value of platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > drivers/devfreq/tegra-devfreq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index 214fff9..ae71215 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - dev_err(&pdev->dev, "Failed to get IRQ\n"); > - return -ENODEV; > + if (irq < 0) { > + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); > + return irq; > } > > platform_set_drvdata(pdev, tegra); > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <5956058A.3090304-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() [not found] ` <5956058A.3090304-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2017-07-01 7:42 ` MyungJoo Ham 0 siblings, 0 replies; 9+ messages in thread From: MyungJoo Ham @ 2017-07-01 7:42 UTC (permalink / raw) To: Chanwoo Choi Cc: Gustavo A. R. Silva, Kyungmin Park, Thierry Reding, Jonathan Hunter, Linux PM list, linux-tegra-u79uwXL29TY76Z2rM5mHXA, LKML On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote: > Hi, > > On 2017년 06월 30일 16:22, Gustavo A. R. Silva wrote: >> Print and propagate the return value of platform_get_irq on failure. >> >> Signed-off-by: Gustavo A. R. Silva <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org> >> --- >> drivers/devfreq/tegra-devfreq.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c >> index 214fff9..ae71215 100644 >> --- a/drivers/devfreq/tegra-devfreq.c >> +++ b/drivers/devfreq/tegra-devfreq.c >> @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) >> } >> >> irq = platform_get_irq(pdev, 0); >> - if (irq <= 0) { >> - dev_err(&pdev->dev, "Failed to get IRQ\n"); >> - return -ENODEV; >> + if (irq < 0) { >> + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); >> + return irq; >> } >> >> platform_set_drvdata(pdev, tegra); >> > > Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Acked-by: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() 2017-06-30 7:22 ` [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() Gustavo A. R. Silva 2017-06-30 8:02 ` Chanwoo Choi @ 2017-07-03 11:35 ` Jon Hunter 2017-07-03 11:59 ` Gustavo A. R. Silva 1 sibling, 1 reply; 9+ messages in thread From: Jon Hunter @ 2017-07-03 11:35 UTC (permalink / raw) To: Gustavo A. R. Silva, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Thierry Reding Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA, linux-tegra-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 30/06/17 08:22, Gustavo A. R. Silva wrote: > Print and propagate the return value of platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org> > --- > drivers/devfreq/tegra-devfreq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index 214fff9..ae71215 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - dev_err(&pdev->dev, "Failed to get IRQ\n"); > - return -ENODEV; > + if (irq < 0) { The changelog does not describe the above change and if/why this is ok. However, the original test looks fine to me and so I don't see a need to change this. > + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); > + return irq; Why not have ... return irq ? irq : -ENODEV; Cheers Jon -- nvpublic ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() 2017-07-03 11:35 ` Jon Hunter @ 2017-07-03 11:59 ` Gustavo A. R. Silva [not found] ` <20170703065905.Horde.JGioNMGT4RgQsy5ykZpOZQ1-fU+oOHjIBR1LoJgMfuPDHBfZZeVsHd8q@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Gustavo A. R. Silva @ 2017-07-03 11:59 UTC (permalink / raw) To: Jon Hunter Cc: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Thierry Reding, linux-pm, linux-tegra, linux-kernel Hi Jon, Quoting Jon Hunter <jonathanh@nvidia.com>: > On 30/06/17 08:22, Gustavo A. R. Silva wrote: >> Print and propagate the return value of platform_get_irq on failure. >> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >> --- >> drivers/devfreq/tegra-devfreq.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/devfreq/tegra-devfreq.c >> b/drivers/devfreq/tegra-devfreq.c >> index 214fff9..ae71215 100644 >> --- a/drivers/devfreq/tegra-devfreq.c >> +++ b/drivers/devfreq/tegra-devfreq.c >> @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct >> platform_device *pdev) >> } >> >> irq = platform_get_irq(pdev, 0); >> - if (irq <= 0) { >> - dev_err(&pdev->dev, "Failed to get IRQ\n"); >> - return -ENODEV; >> + if (irq < 0) { > > The changelog does not describe the above change and if/why this is ok. > However, the original test looks fine to me and so I don't see a need to > change this. > You are right about the changelog. I think this one is much better: platform_get_irq() returns an error code, but the tegra-devfreq driver ignores it and always returns -ENODEV. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af Print error message and propagate the return value of platform_get_irq on failure. What do you think? Thank you! -- Gustavo A. R. Silva ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <20170703065905.Horde.JGioNMGT4RgQsy5ykZpOZQ1-fU+oOHjIBR1LoJgMfuPDHBfZZeVsHd8q@public.gmane.org>]
* Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() [not found] ` <20170703065905.Horde.JGioNMGT4RgQsy5ykZpOZQ1-fU+oOHjIBR1LoJgMfuPDHBfZZeVsHd8q@public.gmane.org> @ 2017-07-03 12:22 ` Jon Hunter 2017-07-03 12:47 ` [PATCH v2] devfreq: tegra: fix error return " Gustavo A. R. Silva 0 siblings, 1 reply; 9+ messages in thread From: Jon Hunter @ 2017-07-03 12:22 UTC (permalink / raw) To: Gustavo A. R. Silva Cc: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Thierry Reding, linux-pm-u79uwXL29TY76Z2rM5mHXA, linux-tegra-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 03/07/17 12:59, Gustavo A. R. Silva wrote: > Hi Jon, > > Quoting Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>: > >> On 30/06/17 08:22, Gustavo A. R. Silva wrote: >>> Print and propagate the return value of platform_get_irq on failure. >>> >>> Signed-off-by: Gustavo A. R. Silva <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org> >>> --- >>> drivers/devfreq/tegra-devfreq.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/devfreq/tegra-devfreq.c >>> b/drivers/devfreq/tegra-devfreq.c >>> index 214fff9..ae71215 100644 >>> --- a/drivers/devfreq/tegra-devfreq.c >>> +++ b/drivers/devfreq/tegra-devfreq.c >>> @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct >>> platform_device *pdev) >>> } >>> >>> irq = platform_get_irq(pdev, 0); >>> - if (irq <= 0) { >>> - dev_err(&pdev->dev, "Failed to get IRQ\n"); >>> - return -ENODEV; >>> + if (irq < 0) { >> >> The changelog does not describe the above change and if/why this is ok. >> However, the original test looks fine to me and so I don't see a need to >> change this. >> > > You are right about the changelog. I think this one is much better: > > platform_get_irq() returns an error code, but the tegra-devfreq > driver ignores it and always returns -ENODEV. This is not correct, > and prevents -EPROBE_DEFER from being propagated properly. > > Notice that platform_get_irq() no longer returns 0 on error: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af Yes the above should be added to the changelog. Looks like someone should update the following for consistency too ... 141 int platform_irq_count(struct platform_device *dev) 142 { 143 int ret, nr = 0; 144 145 while ((ret = platform_get_irq(dev, nr)) >= 0) 146 nr++; > > Print error message and propagate the return value of > platform_get_irq on failure. > > What do you think? Fine with me. Thanks! Jon -- nvpublic ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] devfreq: tegra: fix error return code in tegra_devfreq_probe() 2017-07-03 12:22 ` Jon Hunter @ 2017-07-03 12:47 ` Gustavo A. R. Silva 2017-07-04 8:35 ` Jon Hunter 0 siblings, 1 reply; 9+ messages in thread From: Gustavo A. R. Silva @ 2017-07-03 12:47 UTC (permalink / raw) To: Jonathan Hunter, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Thierry Reding Cc: linux-pm, linux-tegra, linux-kernel, Gustavo A. R. Silva platform_get_irq() returns an error code, but the tegra-devfreq driver ignores it and always returns -ENODEV. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af Print and propagate the return value of platform_get_irq on failure. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- Changes in v2: Rewrite commit message. drivers/devfreq/tegra-devfreq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c index 214fff9..ae71215 100644 --- a/drivers/devfreq/tegra-devfreq.c +++ b/drivers/devfreq/tegra-devfreq.c @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - dev_err(&pdev->dev, "Failed to get IRQ\n"); - return -ENODEV; + if (irq < 0) { + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); + return irq; } platform_set_drvdata(pdev, tegra); -- 2.5.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] devfreq: tegra: fix error return code in tegra_devfreq_probe() 2017-07-03 12:47 ` [PATCH v2] devfreq: tegra: fix error return " Gustavo A. R. Silva @ 2017-07-04 8:35 ` Jon Hunter 2017-07-17 4:52 ` Gustavo A. R. Silva 0 siblings, 1 reply; 9+ messages in thread From: Jon Hunter @ 2017-07-04 8:35 UTC (permalink / raw) To: Gustavo A. R. Silva, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Thierry Reding Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA, linux-tegra-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 03/07/17 13:47, Gustavo A. R. Silva wrote: > platform_get_irq() returns an error code, but the tegra-devfreq > driver ignores it and always returns -ENODEV. This is not correct, > and prevents -EPROBE_DEFER from being propagated properly. > > Notice that platform_get_irq() no longer returns 0 on error: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af > > Print and propagate the return value of platform_get_irq on failure. > > Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Acked-by: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Signed-off-by: Gustavo A. R. Silva <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org> > --- > Changes in v2: > Rewrite commit message. > > drivers/devfreq/tegra-devfreq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index 214fff9..ae71215 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - dev_err(&pdev->dev, "Failed to get IRQ\n"); > - return -ENODEV; > + if (irq < 0) { > + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); > + return irq; > } > > platform_set_drvdata(pdev, tegra); Thanks. Acked-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Cheers Jon -- nvpublic ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] devfreq: tegra: fix error return code in tegra_devfreq_probe() 2017-07-04 8:35 ` Jon Hunter @ 2017-07-17 4:52 ` Gustavo A. R. Silva 0 siblings, 0 replies; 9+ messages in thread From: Gustavo A. R. Silva @ 2017-07-17 4:52 UTC (permalink / raw) To: Jon Hunter, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Thierry Reding Cc: linux-pm, linux-tegra, linux-kernel On 07/04/2017 03:35 AM, Jon Hunter wrote: > > On 03/07/17 13:47, Gustavo A. R. Silva wrote: >> platform_get_irq() returns an error code, but the tegra-devfreq >> driver ignores it and always returns -ENODEV. This is not correct, >> and prevents -EPROBE_DEFER from being propagated properly. >> >> Notice that platform_get_irq() no longer returns 0 on error: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af >> >> Print and propagate the return value of platform_get_irq on failure. >> >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >> --- >> Changes in v2: >> Rewrite commit message. >> >> drivers/devfreq/tegra-devfreq.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c >> index 214fff9..ae71215 100644 >> --- a/drivers/devfreq/tegra-devfreq.c >> +++ b/drivers/devfreq/tegra-devfreq.c >> @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) >> } >> >> irq = platform_get_irq(pdev, 0); >> - if (irq <= 0) { >> - dev_err(&pdev->dev, "Failed to get IRQ\n"); >> - return -ENODEV; >> + if (irq < 0) { >> + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); >> + return irq; >> } >> >> platform_set_drvdata(pdev, tegra); > > Thanks. > > Acked-by: Jon Hunter <jonathanh@nvidia.com> > Thank you, Jon. -- Gustavo A. R. Silva ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-07-17 4:52 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170630072216epcas1p34027491553237c57f0270b3f305f0058@epcas1p3.samsung.com>
2017-06-30 7:22 ` [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() Gustavo A. R. Silva
2017-06-30 8:02 ` Chanwoo Choi
[not found] ` <5956058A.3090304-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-07-01 7:42 ` MyungJoo Ham
2017-07-03 11:35 ` Jon Hunter
2017-07-03 11:59 ` Gustavo A. R. Silva
[not found] ` <20170703065905.Horde.JGioNMGT4RgQsy5ykZpOZQ1-fU+oOHjIBR1LoJgMfuPDHBfZZeVsHd8q@public.gmane.org>
2017-07-03 12:22 ` Jon Hunter
2017-07-03 12:47 ` [PATCH v2] devfreq: tegra: fix error return " Gustavo A. R. Silva
2017-07-04 8:35 ` Jon Hunter
2017-07-17 4:52 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).