From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C47BEC433EF for ; Mon, 4 Jul 2022 08:04:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232837AbiGDIEH (ORCPT ); Mon, 4 Jul 2022 04:04:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232874AbiGDIEG (ORCPT ); Mon, 4 Jul 2022 04:04:06 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 922ED55B2; Mon, 4 Jul 2022 01:04:05 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A776C23A; Mon, 4 Jul 2022 01:04:05 -0700 (PDT) Received: from [192.168.33.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D8BF43F792; Mon, 4 Jul 2022 01:04:03 -0700 (PDT) Message-ID: <89f930df-5276-e3b1-7569-4c62ffdf135a@arm.com> Date: Mon, 4 Jul 2022 09:04:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 04/12] thermal/of: Move thermal_trip structure to thermal.h Content-Language: en-US To: Daniel Lezcano , daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@baylibre.com, abailon@baylibre.com, Amit Kucheria , Zhang Rui , rafael@kernel.org References: <20220703183059.4133659-1-daniel.lezcano@linexp.org> <20220703183059.4133659-5-daniel.lezcano@linexp.org> From: Lukasz Luba In-Reply-To: <20220703183059.4133659-5-daniel.lezcano@linexp.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 7/3/22 19:30, Daniel Lezcano wrote: > The structure thermal_trip is now generic and will be usable by the > different sensor drivers in place of their own structure. > > Move its definition to thermal.h to make it accessible. > > Cc: Alexandre Bailon > Cc: Kevin Hilman > Cc; Eduardo Valentin > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/thermal_core.h | 12 ------------ > include/linux/thermal.h | 12 ++++++++++++ > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h > index ff10cdda056c..60844e2d59bb 100644 > --- a/drivers/thermal/thermal_core.h > +++ b/drivers/thermal/thermal_core.h > @@ -68,18 +68,6 @@ static inline bool cdev_is_power_actor(struct thermal_cooling_device *cdev) > void thermal_cdev_update(struct thermal_cooling_device *); > void __thermal_cdev_update(struct thermal_cooling_device *cdev); > > -/** > - * struct thermal_trip - representation of a point in temperature domain > - * @temperature: temperature value in miliCelsius > - * @hysteresis: relative hysteresis in miliCelsius > - * @type: trip point type > - */ > -struct thermal_trip { > - int temperature; > - int hysteresis; > - enum thermal_trip_type type; > -}; > - > int get_tz_trend(struct thermal_zone_device *tz, int trip); > > struct thermal_instance * > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index 365733b428d8..6289b0bb1c97 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -80,6 +80,18 @@ struct thermal_zone_device_ops { > void (*critical)(struct thermal_zone_device *); > }; > > +/** > + * struct thermal_trip - representation of a point in temperature domain > + * @temperature: temperature value in miliCelsius > + * @hysteresis: relative hysteresis in miliCelsius > + * @type: trip point type > + */ > +struct thermal_trip { > + int temperature; > + int hysteresis; > + enum thermal_trip_type type; > +}; > + > struct thermal_cooling_device_ops { > int (*get_max_state) (struct thermal_cooling_device *, unsigned long *); > int (*get_cur_state) (struct thermal_cooling_device *, unsigned long *); Reviewed-by: Lukasz Luba