From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD52C433F5 for ; Sat, 19 Feb 2022 00:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240356AbiBSA2C (ORCPT ); Fri, 18 Feb 2022 19:28:02 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237337AbiBSA2B (ORCPT ); Fri, 18 Feb 2022 19:28:01 -0500 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C515B7C43 for ; Fri, 18 Feb 2022 16:27:43 -0800 (PST) Received: by mail-il1-x134.google.com with SMTP id v3so635213ilc.7 for ; Fri, 18 Feb 2022 16:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JYKbon0sjmC8OdB1+pUCylkGlnV+3knb0QnDCySZnIw=; b=UyDeiKgG7MnwJIirmRh8gakUGCKk++DgSMZTiEg1ZLGKiNBJO+MtrMz1tBlDXU//AF cWHFPrIohCu/AOHoKZUR+Wm2PiTCit8e1W5/wmMe0Bvj3u7Wmpcu2NkGpMdqlEPLG/bu XPJvxbgaIxjAT6SW7sZpv87qAv4gNN/gYZDMw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JYKbon0sjmC8OdB1+pUCylkGlnV+3knb0QnDCySZnIw=; b=t5KnCYaTycbRRnt5pfs6eXQOpbYRItn+urj6zHaenqecTCQmUM+aNLP45EMIqpvEAj 9z5iDS1aWX/52r9RXaPnblwmTtZgXdwPfA/RDGeea8pvfD0dx5K/n32W6+BoE2ZCYKi+ 0RigLshCcVew+HnTy+8Fl+5BLpOnSSZIbfKA7PghnbqHNYY0RLB4ZzWRmTKQ5uZpzbXy WV7lb59gCLzwiO8OHWhVu2BSVLdynN76yunuyRoVOpEV9vdAG+ps04d3rhWZx2OiKnGb cgvh+dYo/6qzEfPhz2E+mLIMlnL2OIhTaxUxwfwtramCv+YxPnXWXmwcWvlBRJUHA66P Io7g== X-Gm-Message-State: AOAM531PzecWZortpD/X7LPFJRXCvLKYL9mfstH5lcvgFpigEzWsdjIH 9mqWBaozPwMXXDVTwZ0FyKTuSA== X-Google-Smtp-Source: ABdhPJy6ZAFBwwp1IZSsSBg89VsTeKSYTj8aPKKyHGlR/AMvlPzX0pNDp8Mern6FI6wjY9MdXr1drA== X-Received: by 2002:a05:6e02:1be5:b0:2c1:efb6:9698 with SMTP id y5-20020a056e021be500b002c1efb69698mr393555ilv.131.1645230463021; Fri, 18 Feb 2022 16:27:43 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id h6sm3516174ilj.58.2022.02.18.16.27.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Feb 2022 16:27:42 -0800 (PST) Subject: Re: [PATCH RESEND v6 0/9] cpupower: Add AMD P-State Support To: Huang Rui , "Rafael J . Wysocki" , linux-pm@vger.kernel.org Cc: Deepak Sharma , Alex Deucher , Mario Limonciello , Steven Noonan , Nathan Fontenot , Jinzhou Su , Xiaojian Du , Perry Yuan , Jassmine Meng , Borislav Petkov , Peter Zijlstra , Ingo Molnar , Viresh Kumar , Steven Rostedt , Giovanni Gherdovich , linux-kernel@vger.kernel.org, Shuah Khan References: <20220216073558.751071-1-ray.huang@amd.com> From: Shuah Khan Message-ID: <8aafb93a-772c-1806-e087-cd285694aa74@linuxfoundation.org> Date: Fri, 18 Feb 2022 17:27:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220216073558.751071-1-ray.huang@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 2/16/22 12:35 AM, Huang Rui wrote: > Hi Shuah, > > Since AMD P-State kernel is merged into 5.17-rc1, I would like to continue > revising the AMD P-State support for the CPUPower tool. These series are > rebased on latest bleeding-edge, any comments are warm for me. > > See patch series of CPUPower in below git repo: > V1: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v1 > V2: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v2 > V3: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v3 > V4: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v4 > V5: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v5 > V6: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=cpupower-amd-pstate > A few checkpatch warns to fix. I usually ignore CHECK from checkpatch, but a few of them found on this series could improve the code. Also is there a need to add/update manpages and documentation. I tested these my AMD Ryzen 7 4700G system. I didn't play with set commands and just the info ones. cpupower info gave me this output. The first message is fine, but the second one is a bit odd. Should it just bail out right after the first message about "not support" cpupower info System does not support Intel's performance bias setting analyzing CPU 0: Go ahead send me v7 for these and add any mapages/doc if necessary. I will get them into Linux 5.18-rc1 thanks, -- Shuah