public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Perry Yuan <perry.yuan@amd.com>,
	rafael.j.wysocki@intel.com, ray.huang@amd.com,
	viresh.kumar@linaro.org
Cc: Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
	Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
	Xiaojian.Du@amd.com, Li.Meng@amd.com, wyes.karny@amd.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 12/13] cpufreq: amd-pstate: convert sprintf with sysfs_emit()
Date: Mon, 19 Dec 2022 17:31:06 -0600	[thread overview]
Message-ID: <8c6d4a0a-065d-cd01-7799-5f6603c0ebb8@amd.com> (raw)
In-Reply-To: <20221219064042.661122-13-perry.yuan@amd.com>

On 12/19/2022 00:40, Perry Yuan wrote:
> replace the sprintf with a more generic sysfs_emit function
> 
> No potential function impact

Anything is possible!  "No intended functional impact." I believe is 
what you meant =)

> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

With commit message fixed:

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/cpufreq/amd-pstate.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index e8996e937e63..d8b182614c18 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -709,7 +709,7 @@ static ssize_t show_amd_pstate_max_freq(struct cpufreq_policy *policy,
>   	if (max_freq < 0)
>   		return max_freq;
>   
> -	return sprintf(&buf[0], "%u\n", max_freq);
> +	return sysfs_emit(buf, "%u\n", max_freq);
>   }
>   
>   static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *policy,
> @@ -722,7 +722,7 @@ static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *poli
>   	if (freq < 0)
>   		return freq;
>   
> -	return sprintf(&buf[0], "%u\n", freq);
> +	return sysfs_emit(buf, "%u\n", freq);
>   }
>   
>   /*
> @@ -737,7 +737,7 @@ static ssize_t show_amd_pstate_highest_perf(struct cpufreq_policy *policy,
>   
>   	perf = READ_ONCE(cpudata->highest_perf);
>   
> -	return sprintf(&buf[0], "%u\n", perf);
> +	return sysfs_emit(buf, "%u\n", perf);
>   }
>   
>   static ssize_t show_energy_performance_available_preferences(


  reply	other threads:[~2022-12-19 23:31 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19  6:40 [PATCH v8 00/13] Implement AMD Pstate EPP Driver Perry Yuan
2022-12-19  6:40 ` [PATCH v8 01/13] ACPI: CPPC: Add AMD pstate energy performance preference cppc control Perry Yuan
2022-12-19 21:09   ` Limonciello, Mario
2022-12-23  2:16   ` Huang Rui
2022-12-23  3:19     ` Yuan, Perry
2022-12-23  9:06       ` Huang Rui
2022-12-25 16:41         ` Yuan, Perry
2022-12-19  6:40 ` [PATCH v8 02/13] Documentation: amd-pstate: add EPP profiles introduction Perry Yuan
2022-12-19 22:37   ` Limonciello, Mario
2022-12-19  6:40 ` [PATCH v8 03/13] cpufreq: intel_pstate: use common macro definition for Energy Preference Performance(EPP) Perry Yuan
2022-12-20  2:53   ` Mario Limonciello
2022-12-23  3:10   ` Huang Rui
2022-12-23  3:12     ` Yuan, Perry
2022-12-19  6:40 ` [PATCH v8 04/13] cpufreq: amd-pstate: fix kernel hang issue while amd-pstate unregistering Perry Yuan
2022-12-19 22:55   ` Limonciello, Mario
2022-12-19  6:40 ` [PATCH v8 05/13] cpufreq: amd-pstate: optimize driver working mode selection in amd_pstate_param() Perry Yuan
2022-12-19 23:01   ` Limonciello, Mario
2022-12-23  4:23   ` Huang Rui
2022-12-23  9:45   ` Wyes Karny
2022-12-25 16:41     ` Yuan, Perry
2022-12-19  6:40 ` [PATCH v8 06/13] cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors Perry Yuan
2022-12-20  3:09   ` Mario Limonciello
2022-12-23  7:43   ` Huang Rui
2022-12-23  7:52     ` Yuan, Perry
2022-12-19  6:40 ` [PATCH v8 07/13] cpufreq: amd-pstate: implement amd pstate cpu online and offline callback Perry Yuan
2022-12-23  8:11   ` Huang Rui
2022-12-19  6:40 ` [PATCH v8 08/13] cpufreq: amd-pstate: implement suspend and resume callbacks Perry Yuan
2022-12-23  8:12   ` Huang Rui
2022-12-19  6:40 ` [PATCH v8 09/13] cpufreq: amd-pstate: add driver working mode switch support Perry Yuan
2022-12-19 23:38   ` Limonciello, Mario
2022-12-23  8:56   ` Huang Rui
2022-12-25 16:41     ` Yuan, Perry
2022-12-19  6:40 ` [PATCH v8 10/13] Documentation: amd-pstate: add amd pstate driver mode introduction Perry Yuan
2022-12-19 23:28   ` Limonciello, Mario
2022-12-19  6:40 ` [PATCH v8 11/13] Documentation: introduce amd pstate active mode kernel command line options Perry Yuan
2022-12-19 23:29   ` Limonciello, Mario
2022-12-19  6:40 ` [PATCH v8 12/13] cpufreq: amd-pstate: convert sprintf with sysfs_emit() Perry Yuan
2022-12-19 23:31   ` Limonciello, Mario [this message]
2022-12-25 16:42     ` Yuan, Perry
2022-12-23  7:45   ` Huang Rui
2022-12-19  6:40 ` [PATCH v8 13/13] Documentation: amd-pstate: introduce new global sysfs attributes Perry Yuan
2022-12-19 22:35   ` Limonciello, Mario
2022-12-20 18:13 ` [PATCH v8 00/13] Implement AMD Pstate EPP Driver Tor Vic
2022-12-20 18:52   ` Tor Vic
2022-12-21  3:08     ` Yuan, Perry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c6d4a0a-065d-cd01-7799-5f6603c0ebb8@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Deepak.Sharma@amd.com \
    --cc=Li.Meng@amd.com \
    --cc=Nathan.Fontenot@amd.com \
    --cc=Shimmer.Huang@amd.com \
    --cc=Xiaojian.Du@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=perry.yuan@amd.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ray.huang@amd.com \
    --cc=viresh.kumar@linaro.org \
    --cc=wyes.karny@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox