From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Cc: Chen Yu <yu.c.chen@intel.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] cpufreq: intel_pstate: Skip HWP_CAP reads in Broadwell mode
Date: Sun, 21 Jun 2026 14:38:27 -0700 [thread overview]
Message-ID: <8ca52415dcb582b821475eb4bd428846b1861054.camel@linux.intel.com> (raw)
In-Reply-To: <12920597.O9o76ZdvQC@rafael.j.wysocki>
On Fri, 2026-06-19 at 21:24 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> When running in the Broadwell HWP mode, the turbo, max and min
> P-state values are retrieved from MSR_PLATFORM_INFO, so reading
> MSR_HWP_CAPABILITIES in that mode in order to update those values
> is pointless. Moreover, using the MSR_HWP_CAPABILITIES value for
> updating them in the Broadwell mode may be harmful, so avoid doing
> that altogether.
>
> Fixes: de5bcf404ace ("cpufreq: intel_pstate: Clean up frequency
> computations")
Can't apply this patch on the latest Linux master even after applying
prior 6 patches.
What is this based on?
Thanks,
Srinivas
> Link:
> https://sashiko.dev/#/patchset/6005456.DvuYhMxLoT%40rafael.j.wysocki
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: All applicable <stable@vger.kernel.org>
> ---
> drivers/cpufreq/intel_pstate.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1197,6 +1197,9 @@ static void intel_pstate_get_hwp_cap(str
> {
> int scaling = cpu->pstate.scaling;
>
> + if (hwp_mode_bdw)
> + return;
> +
> __intel_pstate_get_hwp_cap(cpu);
>
> cpu->pstate.max_freq = cpu->pstate.max_pstate * scaling;
>
>
>
next prev parent reply other threads:[~2026-06-21 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 19:24 [PATCH v1] cpufreq: intel_pstate: Skip HWP_CAP reads in Broadwell mode Rafael J. Wysocki
2026-06-21 21:38 ` srinivas pandruvada [this message]
2026-06-22 16:38 ` Rafael J. Wysocki
2026-06-22 15:16 ` Chen, Yu C
2026-06-22 17:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ca52415dcb582b821475eb4bd428846b1861054.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox