From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D1DEEAA77 for ; Thu, 14 Sep 2023 21:07:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbjINVHd (ORCPT ); Thu, 14 Sep 2023 17:07:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbjINVHd (ORCPT ); Thu, 14 Sep 2023 17:07:33 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9BBE6269D; Thu, 14 Sep 2023 14:07:28 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82B791FB; Thu, 14 Sep 2023 14:08:05 -0700 (PDT) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 875B13F738; Thu, 14 Sep 2023 14:07:24 -0700 (PDT) Message-ID: <8cfa9edb-67f9-80f9-0a5c-1920f95b338a@arm.com> Date: Thu, 14 Sep 2023 23:07:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/4] energy_model: use a fixed reference frequency Content-Language: en-US To: Vincent Guittot , linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, sudeep.holla@arm.com, gregkh@linuxfoundation.org, rafael@kernel.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org Cc: conor.dooley@microchip.com, suagrfillet@gmail.com, ajones@ventanamicro.com, lftan@kernel.org References: <20230901130312.247719-1-vincent.guittot@linaro.org> <20230901130312.247719-5-vincent.guittot@linaro.org> From: Dietmar Eggemann In-Reply-To: <20230901130312.247719-5-vincent.guittot@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 01/09/2023 15:03, Vincent Guittot wrote: [...] > diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h > index b9caa01dfac4..7ee07be6928e 100644 > --- a/include/linux/energy_model.h > +++ b/include/linux/energy_model.h > @@ -204,6 +204,20 @@ struct em_perf_state *em_pd_get_efficient_state(struct em_perf_domain *pd, > return ps; > } > > +#ifdef arch_scale_freq_ref > +static __always_inline > +unsigned long arch_scale_freq_ref_em(int cpu, struct em_perf_domain *pd) Why is this function named with the arch prefix? So far we have 5 arch functions (arch_scale_freq_tick() <-> arch_scale_freq_ref()) and e.g. Arm/Arm64 defines them with there topology_foo implementations. Isn't arch_scale_freq_ref_em() (as well as arch_scale_freq_ref_policy()) different in this sense and so a proper EM function which should manifest in its name? > +{ > + return arch_scale_freq_ref(cpu); > +} > +#else > +static __always_inline > +unsigned long arch_scale_freq_ref_em(int cpu, struct em_perf_domain *pd) > +{ > + return pd->table[pd->nr_perf_states - 1].frequency; > +} > +#endif [...] > @@ -241,11 +255,11 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd, > */ > cpu = cpumask_first(to_cpumask(pd->cpus)); > scale_cpu = arch_scale_cpu_capacity(cpu); > - ps = &pd->table[pd->nr_perf_states - 1]; > + ref_freq = arch_scale_freq_ref_em(cpu, pd); Why not using existing `unsigned long freq` here like in schedutil's get_next_freq()? > > max_util = map_util_perf(max_util); [...]