From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH v4 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove Date: Wed, 24 Apr 2019 11:38:07 +0200 Message-ID: <8d80c874-956f-b2e2-412b-69cc26235606@linaro.org> References: <20190424051145.23072-1-jiada_wang@mentor.com> <20190424051145.23072-3-jiada_wang@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190424051145.23072-3-jiada_wang@mentor.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jiada Wang , rui.zhang@intel.com, edubezval@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, geert+renesas@glider.be, sergei.shtylyov@cogentembedded.com, marek.vasut+renesas@gmail.com, kuninori.morimoto.gx@renesas.com, hien.dang.eb@renesas.com, fabrizio.castro@bp.renesas.com, dien.pham.ry@renesas.com, biju.das@bp.renesas.com, erosca@de.adit-jv.com, george_davis@mentor.com, joshua_frkuska@mentor.com List-Id: linux-pm@vger.kernel.org On 24/04/2019 07:11, Jiada Wang wrote: > Currently IRQ remains enabled after .remove, later if device is probed, > IRQ is requested before .thermal_init, this may cause IRQ function be > called before device is initialized. > > this patch disables interrupt in .remove, to ensure irq function > only be called after device is fully initialized. > > Signed-off-by: Jiada Wang Reviewed-by: Daniel Lezcano > --- > drivers/thermal/rcar_gen3_thermal.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c > index 065e16f53285..280230951dfe 100644 > --- a/drivers/thermal/rcar_gen3_thermal.c > +++ b/drivers/thermal/rcar_gen3_thermal.c > @@ -307,6 +307,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids); > static int rcar_gen3_thermal_remove(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > + struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev); > + > + rcar_thermal_irq_set(priv, false); > > pm_runtime_put(dev); > pm_runtime_disable(dev); > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7553AC282CE for ; Wed, 24 Apr 2019 09:38:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4307F20878 for ; Wed, 24 Apr 2019 09:38:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fZD7VYFt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726262AbfDXJiP (ORCPT ); Wed, 24 Apr 2019 05:38:15 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:39063 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbfDXJiL (ORCPT ); Wed, 24 Apr 2019 05:38:11 -0400 Received: by mail-wr1-f68.google.com with SMTP id a9so6593606wrp.6 for ; Wed, 24 Apr 2019 02:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KIYWXBy0yVdZQntxiMbH9CRQ0LmxGO1cYhntj34UfNc=; b=fZD7VYFtUre34XHlMUrfXxQgJvQgeXJxUsS2UIrnEFOOJSUQqr3x13upCLFu9nUvbu P+vvzlbVrleng80oUiMu4GlzlXNH6EP7CvMtRckA+LRpN+GF7sdK2ilsfAm/4Lf3pzds su15hNylpbtXU1/MGAhLOZubWXY3UTIPRs0XPaI9yLiUGJ0/GXPwjnuWYZfOjyMaRIBj MZmqyfY+gccgSErsIBdOYD2Z5BT2oVWt/bP1b6Btc+FZLawf30/khy2fg2Wj16D4A6gu wal1Z54UixsE4kU1gk+nym857FItg5jO4Zzx5vyUpMW2rNoDEQnOwbE+vPyldtkBq7yL YaOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KIYWXBy0yVdZQntxiMbH9CRQ0LmxGO1cYhntj34UfNc=; b=oMcXAj+FvE01sN2FXPC9+xJuNdYGDbGgBsyn4yvzmVtREwL3aOwvmQtliVnSxaSrcD kterUffdnMRKz+UA7mJU3afS1ly2BsBN7z1zQ/Vc0paIQW1JTO3fMlUQCcMLKvno+vxy b4pQhTXEF0zPlI1iNebGzKNLFoXIokMBATXCjPGcV9kP0WuNebXTw9FEOw0PTvhXmwD4 qrmabf0JKZ/4OACMk3K+pxa23ekPAi+UJ1hYX4I1IViJrs+5xq2Fij4yvs6geq2XNIeF HU6kWI0FfGz/0ATJ1J6A3WMcYLxH36mdFSr/WcZwQF2W1G2JIhSkreyZSFtaMLMgkS6n mPEg== X-Gm-Message-State: APjAAAXSas8M7QJFVnGa9CHicsk0mOntfSdNeMTp4EPINkcQYT+BdCIA GKamGnhgHok3XYakJdmOFz4Ptg== X-Google-Smtp-Source: APXvYqwygbb7SyomzzY0uiOv/6g6Um0ZMB8SrVbC6/eYdOMg4ZwVS87VRAPz99KlJjZVGZXzCzcXDg== X-Received: by 2002:adf:eb0b:: with SMTP id s11mr22259252wrn.140.1556098689066; Wed, 24 Apr 2019 02:38:09 -0700 (PDT) Received: from [192.168.0.44] (sju31-1-78-210-255-2.fbx.proxad.net. [78.210.255.2]) by smtp.googlemail.com with ESMTPSA id q3sm1133033wrj.24.2019.04.24.02.38.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 02:38:08 -0700 (PDT) Subject: Re: [PATCH v4 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove To: Jiada Wang , rui.zhang@intel.com, edubezval@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, geert+renesas@glider.be, sergei.shtylyov@cogentembedded.com, marek.vasut+renesas@gmail.com, kuninori.morimoto.gx@renesas.com, hien.dang.eb@renesas.com, fabrizio.castro@bp.renesas.com, dien.pham.ry@renesas.com, biju.das@bp.renesas.com, erosca@de.adit-jv.com, george_davis@mentor.com, joshua_frkuska@mentor.com References: <20190424051145.23072-1-jiada_wang@mentor.com> <20190424051145.23072-3-jiada_wang@mentor.com> From: Daniel Lezcano Message-ID: <8d80c874-956f-b2e2-412b-69cc26235606@linaro.org> Date: Wed, 24 Apr 2019 11:38:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190424051145.23072-3-jiada_wang@mentor.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20190424093807.MWMm9DP1GUUB2HAdVVwMRqf1JIxuHmu6NS-ZVmqIJ0Y@z> On 24/04/2019 07:11, Jiada Wang wrote: > Currently IRQ remains enabled after .remove, later if device is probed, > IRQ is requested before .thermal_init, this may cause IRQ function be > called before device is initialized. > > this patch disables interrupt in .remove, to ensure irq function > only be called after device is fully initialized. > > Signed-off-by: Jiada Wang Reviewed-by: Daniel Lezcano > --- > drivers/thermal/rcar_gen3_thermal.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c > index 065e16f53285..280230951dfe 100644 > --- a/drivers/thermal/rcar_gen3_thermal.c > +++ b/drivers/thermal/rcar_gen3_thermal.c > @@ -307,6 +307,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids); > static int rcar_gen3_thermal_remove(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > + struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev); > + > + rcar_thermal_irq_set(priv, false); > > pm_runtime_put(dev); > pm_runtime_disable(dev); > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog