From: Mario Limonciello <mario.limonciello@amd.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
K Prateek Nayak <kprateek.nayak@amd.com>,
x86@kernel.org, Kim Phillips <kim.phillips@amd.com>
Subject: Re: [PATCH v2 1/5] Revert "ACPI: CPPC: Adjust debug messages in amd_set_max_freq_ratio() to warn"
Date: Fri, 8 May 2026 14:09:20 -0500 [thread overview]
Message-ID: <8e2c9db5-fd24-43a2-af0c-cb2cb54f5102@amd.com> (raw)
In-Reply-To: <CAJZ5v0gBTxzkQU1EduyBNx2fCYfVU92XcNU8+AbSZziymBdJJw@mail.gmail.com>
On 5/8/26 14:04, Rafael J. Wysocki wrote:
> On Tue, May 5, 2026 at 1:01 AM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>>
>> Some older systems don't support CPPC in the firmware and this just makes
>> noise for them when booting. Drop back to debug.
>>
>> This reverts commit 21fb59ab4b9767085f4fe1edbdbe3177fbb9ec97.
>>
>> Fixes: 21fb59ab4b976 ("ACPI: CPPC: Adjust debug messages in amd_set_max_freq_ratio() to warn")
>> Suggested-by: Kim Phillips <kim.phillips@amd.com>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> arch/x86/kernel/acpi/cppc.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c
>> index d7c8ef1e354d3..be4c5e9e5ff6f 100644
>> --- a/arch/x86/kernel/acpi/cppc.c
>> +++ b/arch/x86/kernel/acpi/cppc.c
>> @@ -88,19 +88,19 @@ static void amd_set_max_freq_ratio(void)
>>
>> rc = cppc_get_perf_caps(0, &perf_caps);
>> if (rc) {
>> - pr_warn("Could not retrieve perf counters (%d)\n", rc);
>> + pr_debug("Could not retrieve perf counters (%d)\n", rc);
>> return;
>> }
>>
>> rc = amd_get_boost_ratio_numerator(0, &numerator);
>> if (rc) {
>> - pr_warn("Could not retrieve highest performance (%d)\n", rc);
>> + pr_debug("Could not retrieve highest performance (%d)\n", rc);
>> return;
>> }
>> nominal_perf = perf_caps.nominal_perf;
>>
>> if (!nominal_perf) {
>> - pr_warn("Could not retrieve nominal performance\n");
>> + pr_debug("Could not retrieve nominal performance\n");
>> return;
>> }
>>
>> --
>
> It looks like this could be applied without the rest of the series.
> Do you want me to do that?
Yeah; go ahead and pick this one up. Thanks.
>
> Also, do I understand correctly that the rest of the series depends on
> Sumit's patch set at
>
> https://lore.kernel.org/all/20260430142430.755437-2-sumitg@nvidia.com/#r
That's correct.
next prev parent reply other threads:[~2026-05-08 19:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 23:01 [PATCH v2 0/5] Add CPPC HighestFreq support Mario Limonciello
2026-05-04 23:01 ` [PATCH v2 1/5] Revert "ACPI: CPPC: Adjust debug messages in amd_set_max_freq_ratio() to warn" Mario Limonciello
2026-05-05 16:30 ` Kim Phillips
2026-05-08 19:04 ` Rafael J. Wysocki
2026-05-08 19:09 ` Mario Limonciello [this message]
2026-05-08 19:17 ` Rafael J. Wysocki
2026-05-08 19:21 ` Mario Limonciello
2026-05-04 23:01 ` [PATCH v2 2/5] ACPI: CPPC: Add support for reading HighestFreq Mario Limonciello
2026-05-04 23:01 ` [PATCH v2 3/5] ACPI: CPPC: Refactor boost ratio handling Mario Limonciello
2026-05-04 23:01 ` [PATCH v2 4/5] cpufreq/acpi-cpufreq: Use amd_get_boost_ratio() Mario Limonciello
2026-05-04 23:01 ` [PATCH v2 5/5] cpufreq/amd-pstate: Get highest freq from CPPC if available Mario Limonciello
2026-05-07 9:33 ` [PATCH v2 0/5] Add CPPC HighestFreq support K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e2c9db5-fd24-43a2-af0c-cb2cb54f5102@amd.com \
--to=mario.limonciello@amd.com \
--cc=kim.phillips@amd.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox