From: Val Packett <val@packett.cool>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Sebastian Reichel <sre@kernel.org>,
Fenglin Wu <fenglin.wu@oss.qualcomm.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] power: supply: qcom_battmgr: improve charge control threshold handling
Date: Mon, 3 Nov 2025 00:46:13 -0300 [thread overview]
Message-ID: <8f003bfb-8279-4c65-a271-c1e4a029043d@packett.cool> (raw)
In-Reply-To: <176213091335.301408.9120443011267055817.b4-ty@collabora.com>
On 11/2/25 9:48 PM, Sebastian Reichel wrote:
> On Sun, 12 Oct 2025 20:32:17 -0300, Val Packett wrote:
>> Currently, upowerd is unable to turn off the battery preservation mode[1]
>> on Qualcomm laptops, because it does that by setting the start threshold to
>> zero and the driver returns an error:
>>
>> pmic_glink.power-supply.0: charge control start threshold exceed range: [50 - 95]
>>
>> Kernel documentation says the end threshold must be clamped[2] but does
>> not say anything about the start threshold.
>>
>> [...]
> Applied, thanks!
>
> [1/2] power: supply: qcom_battmgr: clamp charge control thresholds
> commit: 8809980fdc8a86070667032fa4005ee83f1c62f3
> [2/2] power: supply: qcom_battmgr: support disabling charge control
> commit: 446fcf494691da4e685923e5fad02b163955fc0e
Woahh.. please revert the second one.
I'm sorry, I thought this was discussed here but apparently it was only
on IRC and I must've assumed that the patches weren't going anywhere
because of the lack of R-b..
The disable bit was acting rather strange after all, we'd need more work
to figure out if that's even possible. Let's leave it at the clamp only.
~val
next prev parent reply other threads:[~2025-11-03 3:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-12 23:32 [PATCH 0/2] power: supply: qcom_battmgr: improve charge control threshold handling Val Packett
2025-10-12 23:32 ` [PATCH 1/2] power: supply: qcom_battmgr: clamp charge control thresholds Val Packett
2025-10-13 9:43 ` Konrad Dybcio
2025-10-12 23:32 ` [PATCH 2/2] power: supply: qcom_battmgr: support disabling charge control Val Packett
2025-11-17 5:22 ` Fenglin Wu
2025-11-03 0:48 ` [PATCH 0/2] power: supply: qcom_battmgr: improve charge control threshold handling Sebastian Reichel
2025-11-03 3:46 ` Val Packett [this message]
2025-11-03 14:41 ` Sebastian Reichel
2025-11-17 5:12 ` Fenglin Wu
2025-11-17 12:45 ` Konrad Dybcio
2025-11-18 2:29 ` Fenglin Wu
2025-11-18 10:13 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f003bfb-8279-4c65-a271-c1e4a029043d@packett.cool \
--to=val@packett.cool \
--cc=fenglin.wu@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox