From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA78CCA485 for ; Sun, 19 Jun 2022 11:12:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236225AbiFSLMw (ORCPT ); Sun, 19 Jun 2022 07:12:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236103AbiFSLMu (ORCPT ); Sun, 19 Jun 2022 07:12:50 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5448CBC1 for ; Sun, 19 Jun 2022 04:12:47 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id z7so11482466edm.13 for ; Sun, 19 Jun 2022 04:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=0bO4N/uSieqHtAnXgf/1baS2dwMBhkMs6Pm0kaBNkWE=; b=E4/RD8c9rgPv1AHiFlOx3T32aiVVENFAPBzZ9eV0RNHaZapFln+0wSq/1SvWdjT7/w tY0sACxJsQ+bpZtP51DRVW/qXg/pG5lSvr939MlZdLH3ym40kjJdxzBLp1VGbXUYM4K3 +qH1aUL9URwDODcWkf+uniMnQzkcUoDPXaVuQirmuPerVEIeFM4796MtJD3w1kElqwEj MKcrnBGR4Sanhvm8dGCsbRVNZX5w9TQDsh8wTbaaOrhL+m0JfZqLITvwbPTn4MXVdtm0 54rg7Nun0IsRPjJwYggAKcsRYquLxH0KpHwH0rS4qCdZwe/qRWEmb+bncbHYUGbi9hSE 0fPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0bO4N/uSieqHtAnXgf/1baS2dwMBhkMs6Pm0kaBNkWE=; b=REZxyUAPsNjsrnSFvzcgnQAIHiGaWA8MyXzPNC6FXkZyUQ6DuiXTb26qe3RL2pf2oD epmqPByZ5bwtdbHv4lN6GLQNHx/ifB8KTcEmloGptqzYu8OdRE0wpmItUHw6+px2icxI Jeaia5vDp8/Llkq24JnkUxvrapHJpbdUy9iO6sTEunEn86F2upE45mcIpVzBpOQSrQ+1 3rF8aynXauqJgPD+NPuURhyIZRgDurCCIx/+isf2miaLJAO+qHp8b8iXcpdHdk2qpSLQ NlMuwyfn6WcwPzMnyBt3SRwEriLpwLj7ollhfDDdjhvQLF9HzXiQtip3ZYsnuc+19UIY DaKw== X-Gm-Message-State: AJIora+rmsWXUgtQtwjayDlNK70ckSZ/wSGe1cml000lY8WiV4quXlig zq5VtXsa3SNCk1xeadykYkDgatAZa7fVuQ== X-Google-Smtp-Source: AGRyM1sz0sgafrtoHUw3Rga320+sJuYPhf/shTkqFB8UnCO7EmRgYnNSdcZbJGtmYHwsovZ6x1Cdhw== X-Received: by 2002:a05:6402:35d0:b0:42e:1a76:67ae with SMTP id z16-20020a05640235d000b0042e1a7667aemr23346476edc.311.1655637165805; Sun, 19 Jun 2022 04:12:45 -0700 (PDT) Received: from [192.168.0.206] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id 2-20020a170906318200b006fe98fb9523sm4489330ejy.129.2022.06.19.04.12.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jun 2022 04:12:45 -0700 (PDT) Message-ID: <8faae2a3-6758-979c-e7b0-1d4b18ae1a5b@linaro.org> Date: Sun, 19 Jun 2022 13:12:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 06/16] dt-bindings: gpio: Add AXP192 GPIO bindings Content-Language: en-US To: Aidan MacDonald , linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, wens@csie.org, jic23@kernel.org, lee.jones@linaro.org, sre@kernel.org, broonie@kernel.org, gregkh@linuxfoundation.org, lgirdwood@gmail.com Cc: lars@metafoo.de, rafael@kernel.org, quic_gurus@quicinc.com, sebastian.reichel@collabora.com, andy.shevchenko@gmail.com, michael@walle.cc, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org References: <20220618214009.2178567-1-aidanmacdonald.0x0@gmail.com> <20220618214009.2178567-7-aidanmacdonald.0x0@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220618214009.2178567-7-aidanmacdonald.0x0@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 18/06/2022 23:39, Aidan MacDonald wrote: > The AXP192 PMIC is different enough from the PMICs supported by > the AXP20x GPIO driver to warrant a separate driver. The AXP192 > driver also supports interrupts and pinconf settings. > > Signed-off-by: Aidan MacDonald > --- > .../bindings/gpio/x-powers,axp192-gpio.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml b/Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml > new file mode 100644 > index 000000000000..1e368cac9d3a > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/gpio/x-powers,axp192-gpio.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: X-Powers AXP192 GPIO Device Tree Bindings > + > +maintainers: > + - Chen-Yu Tsai > + > +properties: > + compatible: > + const: x-powers,axp192-gpio > + > + gpio-controller: true > + > + "#gpio-cells": > + const: 2 > + description: > > + The first cell is the pin number and the second is the GPIO flags. > + > + gpio-ranges: > + maxItems: 1 > + > +patternProperties: > + "-pins$": > + $ref: /schemas/pinctrl/pinmux-node.yaml# > + > + properties: > + pins: > + items: > + enum: > + - GPIO0 > + - GPIO1 > + - GPIO2 > + - GPIO3 > + - GPIO4 > + - N_RSTO > + > + function: > + enum: > + - output > + - input > + - ldo > + - pwm > + - adc > + - low_output > + - floating > + - ext_chg_ctl > + - ldo_status > + > +required: > + - compatible > + - "#gpio-cells" > + - gpio-controller > + - gpio-ranges > + > +additionalProperties: false > + > +examples: > + - | > + pinctrl0: gpio@0 { Unit address without reg, that's not a valid DTS. > + compatible = "x-powers,axp192-gpio"; > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&pinctrl0 0 0 6>; > + }; Best regards, Krzysztof