From: Krzysztof Kozlowski <krzk@kernel.org>
To: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Tipton <mike.tipton@oss.qualcomm.com>
Subject: Re: [PATCH 1/3] dt-bindings: interconnect: add clocks property to enable QoS on sa8775p
Date: Tue, 12 Aug 2025 12:17:27 +0200 [thread overview]
Message-ID: <90b51e31-3217-4483-bb5b-ec328665a723@kernel.org> (raw)
In-Reply-To: <20250808140300.14784-2-odelu.kukatla@oss.qualcomm.com>
On 08/08/2025 16:02, Odelu Kukatla wrote:
> Add reg and clocks properties to enable the clocks required
> for accessing QoS configuration.
Nothing here explains why EXISTING hardware is being changed. I also
remember big discussions and big confusing patches regarding sa8775p
(its rename, dropping/changing all providers), and this patch feels like
pieces of it without proper justification.
And this is hidden ABI break, no justification, no mentioning either.
Again we are discussing basics of ABI breaking patches?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-12 10:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 14:02 [PATCH 0/3] Enable QoS configuration on SA8775P Odelu Kukatla
2025-08-08 14:02 ` [PATCH 1/3] dt-bindings: interconnect: add clocks property to enable QoS on sa8775p Odelu Kukatla
2025-08-12 10:17 ` Krzysztof Kozlowski [this message]
2025-08-13 5:55 ` Odelu Kukatla
2025-08-13 6:02 ` Krzysztof Kozlowski
2025-08-20 8:51 ` Odelu Kukatla
2025-08-24 9:08 ` Krzysztof Kozlowski
2025-08-28 18:16 ` Odelu Kukatla
2025-08-28 18:20 ` Krzysztof Kozlowski
2025-08-28 21:59 ` Georgi Djakov
2025-09-03 12:42 ` Konrad Dybcio
2025-09-03 18:01 ` Odelu Kukatla
2025-08-28 22:36 ` Dmitry Baryshkov
2025-08-08 14:02 ` [PATCH 2/3] interconnect: qcom: sa8775p: enable QoS configuration Odelu Kukatla
2025-08-09 7:35 ` Dmitry Baryshkov
2025-08-12 10:25 ` Odelu Kukatla
2025-08-08 14:03 ` [PATCH 3/3] arm64: dts: qcom: sa8775p: Add clocks for " Odelu Kukatla
2025-08-09 7:36 ` Dmitry Baryshkov
2025-08-12 9:51 ` Konrad Dybcio
2025-08-13 5:45 ` Odelu Kukatla
2025-08-15 13:11 ` Georgi Djakov
2025-08-19 9:10 ` Odelu Kukatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90b51e31-3217-4483-bb5b-ec328665a723@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mike.tipton@oss.qualcomm.com \
--cc=odelu.kukatla@oss.qualcomm.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).