From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AD031F9F4F for ; Fri, 3 Jan 2025 11:49:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735904942; cv=none; b=tP2ybEMuFiaen/qCnMhhFjq+ZIwER2qceqymLR3+yCRV/+74E9xms8orJCWhfKxtXuUbJKW93I2NCXHaI2oeYUUH4JLGJzOysOXT/xm0BCCVZJ8a8sZ4tfze4e6vbWBoB1g/6IBqJZFKE0ToKn7Y3WnJ0Sg1Nhn4Ba/OEu8f3tQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735904942; c=relaxed/simple; bh=NLd1X0clRT7iGn/Sxk5o+itD4OrXYuoZrJYJ4szklTg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mLg1Z6VmKwQdIg2TtHrOR56TnrjDWQrZGRwMUCHVsZIb2m3prJjeb5tPtaz8MevkRFpOSoq05ti1wYVvGIk26kK7t4Rweiic9K4ekyqHk1+7efPqpDeJOe52MkyhCkoUoZ87FkTk9fTYzkQAYzVUD4nzlzO3JYkTldfouyeSXbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eCsIUbN1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eCsIUbN1" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 503BIVk3007233 for ; Fri, 3 Jan 2025 11:49:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kSr8QRPbWyeuYtAJXhV7CqtuHNejTbL/irUiflDNBWI=; b=eCsIUbN1EJD6dspX Qa5XsuPdhU7dlEEHrNHoj0OsT9moNzhmr//xtCO8BewROYirQK5NTOxbdZJ8oI1B VvlcdEjcjjV6VW/KZFcXAJPveRx/ICXxCkzAO/7i2TnLmKcNkcIoYT1QLxQIn8r8 oOxKsSmnG+UahVQ16MPjFVhc+OIngAG+xx5Ck8ezzLNJbWXF+Y4BrIlQhpc+Hq+z +UL9b1/BHBgHlTIwAXmTTPU/DuuyTnA2kMR/s+DngcjV6d/Ho5D5/rMFiUvHYwvc WrdpizFg8TPNEbjVuXbm6vpG+xOsqgLRGx2wuOOsvRWOOWYfsf4KLkvbWchO0Sd1 tb7iUg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43xewfg1t5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 03 Jan 2025 11:48:59 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6d8f15481bbso28677006d6.1 for ; Fri, 03 Jan 2025 03:48:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735904938; x=1736509738; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kSr8QRPbWyeuYtAJXhV7CqtuHNejTbL/irUiflDNBWI=; b=DOFnRqwR7ggKhJS1Qq8TAsWpBeE1fORhloAvcmV5oK/wiZ5QSyERr66IXPo82QrdbA fryXzWPA5pTChd0FlVuJO3Z6KD1weEqAVvXBq1QbwHVxkwke9hoNdB7qWSh8HnptBmuY 3a1JVSNgzyRdwerWjLfeIbKjzKGqgOJk6lhIVTIjN360SjgDjSBnnmLxyM81nFgnkV5r SxSYl81pHqt6/xXlslw2hqJWXlW/z8gOBBABTYW5cSil6KFbFlFiRyiBI6CNorQCeMHy lzt72wTH1uLRDDCtC3HX6JYXlZnOxeGfbhWlYvKt1xVl6/xfPwuTf67alTDWZcEu+BBU HlFA== X-Forwarded-Encrypted: i=1; AJvYcCUX62TnqM4mkd+ptKFQCCmCzsyxv5Gl0euPRhw82rGQdOsKbiJM+N+9t/pVzf4oeK5k0azSs1GLkA==@vger.kernel.org X-Gm-Message-State: AOJu0Ywiv4EFR479IqeZWwB4HKbagxi1CFy1734+LTq7lko2RnotorFn v8J4Ok8GaKok5ChkWTf8Mrhb9Hnl1y82AnrYfb7iuNJ7RI8RGRibmUXYINUVRnXZsZdbwxFcygW 9K0eZjzDcjxElKgbBivtRdS9Ceg/dndRKy0TSgDleI7i3B+Ot/2afl/JsCQ== X-Gm-Gg: ASbGncuXyJOwSc9nItACigqwBn/GUIK7pEcQ8o35RZWdI9KswQ91AQrjWia7g6eNT2R CCdLyn5WNQ908yDjPzLxqXsiEaE5Z1H4Di11zFC7rxfI323pwB1PznluSHs9zAo2Fo3qFtCZXQb kDQi5p8JlukMFEqwtTlW8brp0WW/Tl17Q6BDqHKPcxryoQWQobsA4adNfUy/ikfq7BaR5vNGbQY 8sRzZ1i+nZrBriULjfG8a+7vsogdrlHXlAvKQAUFcJ0r3xhKL2NXEtGVaaCIOI/tXAYmnUA9TkU NuhKU8AYZqqBEFbMzKDscavBd9wH2T3Sx14= X-Received: by 2002:a05:622a:199a:b0:467:85f9:2a72 with SMTP id d75a77b69052e-46a4a6a51camr298064951cf.0.1735904938621; Fri, 03 Jan 2025 03:48:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeaakE33Peugzgz4XJzULmcsT1OumHdl1qg3wXiidDFearGseoLbBPjIsRixnqTRiKwVCreA== X-Received: by 2002:a05:622a:199a:b0:467:85f9:2a72 with SMTP id d75a77b69052e-46a4a6a51camr298064781cf.0.1735904938243; Fri, 03 Jan 2025 03:48:58 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e82f60asm1912866266b.28.2025.01.03.03.48.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jan 2025 03:48:57 -0800 (PST) Message-ID: <95f25457-c1dd-4125-8f0d-46d87a1d5356@oss.qualcomm.com> Date: Fri, 3 Jan 2025 12:48:55 +0100 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme-pci: Shutdown the device if D3Cold is allowed by the user To: Christoph Hellwig , Konrad Dybcio Cc: "Rafael J. Wysocki" , Manivannan Sadhasivam , Ulf Hansson , "Rafael J. Wysocki" , Bjorn Helgaas , kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, Len Brown , linux-pm@vger.kernel.org References: <20241209143821.m4dahsaqeydluyf3@thinkpad> <20241212055920.GB4825@lst.de> <13662231.uLZWGnKmhe@rjwysocki.net> <20241212151354.GA7708@lst.de> <20241214063023.4tdvjbqd2lrylb7o@thinkpad> <20241216162303.GA26434@lst.de> <20250103072805.GB28920@lst.de> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250103072805.GB28920@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 3rpY5TsqCZpi4tKlqNl-8Vxr159JmxT2 X-Proofpoint-ORIG-GUID: 3rpY5TsqCZpi4tKlqNl-8Vxr159JmxT2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 malwarescore=0 spamscore=0 mlxlogscore=999 clxscore=1015 suspectscore=0 bulkscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501030104 On 3.01.2025 8:28 AM, Christoph Hellwig wrote: > On Fri, Dec 20, 2024 at 04:15:21PM +0100, Konrad Dybcio wrote: >> The Qualcomm platform (or class of platforms) we're looking at with this >> specific issue requires PCIe (implying NVMe) shutdown for S2RAM. >> >> The S2RAM entry mechanism is unfortunately misrepresented as an S2Idle >> state by Linux as of today, and I'm trying really hard to convince some >> folks to let me describe it correctly, with little success so far.. > > Well, not advertizing the right mechanism isn't going to cause havoc > to any scheme. > >> That is the real underlying issue and once/if it's solved, this patch >> will not be necessary. > > Well, maybe this thread gave good enough fodder to finally fix it? Oh I'd love to.. But my changes are getting rejected over philosophical FW design disagreements, it seems. Konrad > >> >>> In theory, ACPI S3 or hibernation may request that, but I've never >>> seen it happen in practice. >>> >>> Suspend-to-idle on x86 may want devices to end up in specific power >>> states in order to be able to switch the entire platform into a deep >>> energy-saving mode, but that's never been D3cold so far. >> >> In our case the plug is only pulled in S2RAM, otherwise the best we can >> do is just turn off the devices individually to decrease the overall >> power draw > > FYI, going to D3 for S2RAM seems perfectly reasonable from the NVMe POV. >