From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA929C5AD4C for ; Mon, 20 Nov 2023 15:23:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233163AbjKTPX6 (ORCPT ); Mon, 20 Nov 2023 10:23:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232515AbjKTPX6 (ORCPT ); Mon, 20 Nov 2023 10:23:58 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B35EFBE; Mon, 20 Nov 2023 07:23:54 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BCC73FEC; Mon, 20 Nov 2023 07:24:40 -0800 (PST) Received: from [10.57.4.99] (unknown [10.57.4.99]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D8863F6C4; Mon, 20 Nov 2023 07:23:51 -0800 (PST) Message-ID: <96565d08-8d6b-4a37-8a83-90bdd53ba89a@arm.com> Date: Mon, 20 Nov 2023 15:24:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 8/9] thermal: exynos: use BIT wherever possible Content-Language: en-US To: Mateusz Majewski Cc: Bartlomiej Zolnierkiewicz , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , linux-kernel@vger.kernel.org, Amit Kucheria , Zhang Rui , Alim Akhtar , Liam Girdwood , Mark Brown , Marek Szyprowski References: <20231120145049.310509-1-m.majewski2@samsung.com> <20231120145049.310509-9-m.majewski2@samsung.com> From: Lukasz Luba In-Reply-To: <20231120145049.310509-9-m.majewski2@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Mateusz, On 11/20/23 14:50, Mateusz Majewski wrote: > The original driver did not use that macro and it allows us to make our > intentions slightly clearer. > > Signed-off-by: Mateusz Majewski > --- > drivers/thermal/samsung/exynos_tmu.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > [snip] > @@ -590,15 +590,15 @@ static void exynos5433_tmu_control(struct platform_device *pdev, bool on) > continue; > > interrupt_en |= > - (1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i)); > + BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i); > } > > interrupt_en |= > interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT; > > - con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT); > + con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT); > } else Minor issue: the if-else segment here. When the 'if' has the brackets, then the 'else' should have them as well, even if there is only a single line under 'else'. It's not strictly to this patch, but you can address that later somewhere (just saw it here). > - con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT); > + con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT); > > pd_det_en = on ? EXYNOS5433_PD_DET_EN : 0; > > @@ -622,17 +622,17 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on) > continue; > > interrupt_en |= > - (1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i)); > + BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i); > } > > interrupt_en |= > interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT; > > - con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT); > - con |= (1 << EXYNOS7_PD_DET_EN_SHIFT); > + con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT); > + con |= BIT(EXYNOS7_PD_DET_EN_SHIFT); > } else { > - con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT); > - con &= ~(1 << EXYNOS7_PD_DET_EN_SHIFT); > + con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT); > + con &= ~BIT(EXYNOS7_PD_DET_EN_SHIFT); > } > > writel(interrupt_en, data->base + EXYNOS7_TMU_REG_INTEN); The patch LGTM, Reviewed-by Lukasz Luba Regards, Lukasz