From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56958C433EF for ; Thu, 30 Jun 2022 13:27:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235206AbiF3N10 (ORCPT ); Thu, 30 Jun 2022 09:27:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235195AbiF3N1Z (ORCPT ); Thu, 30 Jun 2022 09:27:25 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE12733E35 for ; Thu, 30 Jun 2022 06:27:24 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id l2-20020a05600c4f0200b0039c55c50482so1729043wmq.0 for ; Thu, 30 Jun 2022 06:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=3uL7S2W5wN/+jflQoV3bAbJ3bLJFCX03amVujxIJvq8=; b=Sf992KZuXqlhIEbSl5nytEW8JG+Gggb/JBkLjKDkc7HEXX3mVbyfncyj6CD1e98zM9 0qM9OWjWT98QLgm1X9PbtzVnhLUril+7ZvbD4aVXzDjRhqFO2I+1G6JTrZm185BbEDju /LN5+Y2pNqNXMOcqVceMhZQ0g7iHwjbwm4ovi3D0i5eQMvi1SLqBIYST0+XmXknh7XgX mVEht5mx0PhKef/JNl+C9P5l963AeTY3fV2QRNspiyCewDXbJvWqVFDJm6wUPxsVVCfi /lqZDM1LIQdmg8cpGHCV4PwWzE8dJZ6YH3uQfv82Y9hID4fDkWlDU8rpGr3i0q/VFGKU I5rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3uL7S2W5wN/+jflQoV3bAbJ3bLJFCX03amVujxIJvq8=; b=ai72uUs63A7Q5GdAWCzsQQNBKeqBTkSJs5zjHd3njCLju++bFKdt7u6r1TYM89usH6 sY2Gq+kQHt0K1XJyBxIhnt62lxGy3dv4Pq7NtR2EbO8crazj9sg5mJdmAKbUiI7BkDGJ nekydkglIWjQWU27RQDKXEvgoReHv+FrOtKVSHhWdBZ74syf+xK5ZuTqTObx35EKdEo6 fDLNymUuFr3jwMEdjXQPxZYZW8rhDR/pvBdw4iymX/59VDH50LcrNBF6jzCMd1npGo9U kjqs0l8s2BerOhf71x4VDFM3KvbNbuj8tNgIZYL6+Sg9rc90q0k/5YThj3KoYWD/8Ei1 qtTA== X-Gm-Message-State: AJIora9CiqoEKj81xMXn0ophJvxa6E4qoxt9QvfLWSvq1GXYyOHs0JU0 GV8y8AtCfZYf6mO6GwFfC7Q8XQ== X-Google-Smtp-Source: AGRyM1vSCfsiFnrzxnn7W5JSa663yVGfHgulBXFGfZ6n0K7cwsry5Z7ZfRhLnbIP8qtFYvXWSvgoIA== X-Received: by 2002:a05:600c:3659:b0:3a0:3915:8700 with SMTP id y25-20020a05600c365900b003a039158700mr9687564wmq.127.1656595643117; Thu, 30 Jun 2022 06:27:23 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id h3-20020adfe983000000b0021b97ffa2a9sm20114787wrm.46.2022.06.30.06.27.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jun 2022 06:27:22 -0700 (PDT) Message-ID: <986d197e-f40c-8fd8-449f-3f62b8366e60@linaro.org> Date: Thu, 30 Jun 2022 15:27:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 3/3] thermal/drivers/u8500: Remove the get_trend function Content-Language: en-US To: Vincent Guittot Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Amit Kucheria , Zhang Rui , rafael@kernel.org References: <20220616202537.303655-1-daniel.lezcano@linaro.org> <20220616202537.303655-3-daniel.lezcano@linaro.org> <0a6c992d-ea88-c3fe-1837-8be4e912d266@linaro.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Vincent, On 30/06/2022 14:32, Vincent Guittot wrote: > On Thu, 30 Jun 2022 at 12:16, Daniel Lezcano wrote: >> >> On 28/06/2022 14:50, Linus Walleij wrote: >>> On Tue, Jun 28, 2022 at 10:40 AM Daniel Lezcano >>> wrote: >>> >>>> Adding Linus who is missing in the recipient list. >>>> >>>> >>>> On 16/06/2022 22:25, Daniel Lezcano wrote: >>>>> The get_trend function relies on the interrupt to set the raising or >>>>> dropping trend. However the interpolated temperature is already giving >>>>> the temperature information to the thermal framework which is able to >>>>> deduce the trend. >>>>> >>>>> Remove the trend code. >>>>> >>>>> Signed-off-by: Daniel Lezcano >>> >>> I certainly trust you with this :) >>> Acked-by: Linus Walleij >>> >>> The code was originally written by Hongbo Zhang, but co-developed >>> and tested by Vincent Guittot I think, so paging >>> him as well. >> >> Ok, thanks >> >> If Vincent has no concern with this change, I'll queue up the series > > I don't have any particular concerns. I'm just curious, are you > planning to remove the get_trend completely from the thermal framework > ? Well, actually the get_trend() ops was added for ACPI and because the ops was there, some drivers provided their own implementation and it appears they are unnecessary. It is this pointless code I want to remove. Only the get_trend() ops will remain for the ACPI. Hopefully we can remove the ops in the future. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog