From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646CD403B0E for ; Wed, 9 Sep 2026 07:16:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788938194; cv=none; b=GgH8pvlZ4G0KrqIpVpWDrRLrXYmnrb+E+T6/7qIp1AtZQMYHRuU17zQQDNIPDU4V3lAmrovLT1A5ZMb9nGorWlgBh1pXaG5C2icLAULhlrKm5zRLvnXCcdjsB2KBIBOvSFRPpHlRML5ubEEITjDol036gcEQ+3jYOfYdnq0heeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788938194; c=relaxed/simple; bh=p7ULQTwvLEY4mzWiAczUTaKtFQR3U8NJFvhHihr+q4M=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=AegFrGpG3VbnuEALoXisKT7Zc2E81rBaOrs4RamwzmBz/x1x5h2NKP8LR1DM0GDiYHIIzMiSCSK38VH8LJSYTMQ491gqw2zlsXrrGaOeeKkxPOAXnGxs10VoUcpnRI9bMipFPKumyBKX067liG6VRp2rtjezi+Wp9JBuRVxpQhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gOf7E206; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gOf7E206" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-482f2ee53e7so4057376f8f.1 for ; Wed, 09 Sep 2026 00:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1788938190; x=1789542990; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GN8ZAvEDJoptyik8cMBJpX0S8SH4Ew7cdo5nMOI+S14=; b=gOf7E2060QteZd5OhAI/0iJYqaObx4YFMowTiQwvlV0buCA89kHkhe/nA/jvEz8PhC 5kIZY/hAXw7d3XLKMcLGGWpqVFOdLhsX/gaC/NskPOSFUaeX9qnjZhpdbqM/OIU18gPo XVLpw56nxR8/M6uo817Y12JIffQ4/GSPONskgtwNZZ4fP13+Wz/gY5I93RQ1Mqzfg2b6 8ILezbF6+1WZEcdlvpA5eA4r2EShgNA/fNcfdvgBN8vY88ZVF1c9E8GeW2mFRCK7SUUd 30BMjJMH3GLS1ECCXCSMMLqaTzDauiixOKz84+LsbGe7/8P4fUx09Fgz6qISZwTKlihv 5lwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788938190; x=1789542990; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=GN8ZAvEDJoptyik8cMBJpX0S8SH4Ew7cdo5nMOI+S14=; b=k/llbvDWLctI2IAjFxdQfjb7LZo3UP+gzZpivmGi2xTAclU98CACwphDs5jDjZbXIZ bRhI8hdIEegerULLmTJ0UADvlPeaeqqc2v7lx0wCShB3JIpyBJMG2Ty8RhmKen29eyzT BAtw01bkNeWHasFgGZMCrGKql39HEp/IjC2XLemhkERbi2i4uXtLeWf1eowBV2nKzmn4 y46svxFuWPhNhr1dH2i7NDQgeh4sbFVqicrZNnfHIxokfqBNfY8RQBv8nwfaXhRnPJe2 Z3TCwjmz+dCE9pZVmxrZxmgPdRnFvgdbsKmANAJmAJC/thyRk2jFrB51qWdQCZuLn+Bi hOJA== X-Forwarded-Encrypted: i=1; AKwUvBxznVhs2rNNKlw04XAonaDQ1wG0lfEGCRhVsvEWuDtSYRQnU9mwTYBA1vSDKdeO5Ny2ayGEXmPk7g==@vger.kernel.org X-Gm-Message-State: AFuF++kPEm/vIdm1q2uCYnSST0ivL0zs0I1Jgl3osVq4cTrbhZ2rlKzl 49ekzG1lObO9ayd4k+wwy/J3IiKd2+e2fjz5Dil/S8rHwLS5p3Hl5GXaVf/rLHiZmFE= X-Gm-Gg: AYBFou1X5EJZklDnGZouOOjmNjwwrHGzcL6Btx3jOXxB2hf/ERRPgaqq67wFt/R3ZOF tI4g7DeiNGKqHHrJnl34sty2U7xRcuyorKAxCo9dOZfmvxNcIHCcq+uTgjvA7TStqormisvy50X U9Yjrsp2nXgoeZN1ERVzTpmlswgaYLn5HhrUsOhPceuKvydVPW/1/4KrAkoIELSUmc00JV2zriT hRADjE8sZxIkKNwUM/I7z0mBiLThIbdQanGdMgpQv/XdSNZSDtDW9zGh2yF6bX/G4sa31bIHw0v cyQ9UBRaVcBZSphzGgy0LQTA6+idTsD1vvWItFiL4RVSaMnYXVQaNDYRF91cPHSFqShK+FY2ku3 TCiLNdp5vkUhEaCtp1yEVM0ftv9uLZz/5imnVXpzBK8yza2dLkea3QZK5y473EW1NxSebfM+UJN nHZ6XasP/3L1bwkLNS6h+z7yHiLGRzgXI3qVrzaZPrWnYsU8/Gk6K68f3mePIjXVm+0gFx+68F7 8mfsXY31S4bDTJuhxrb7p9agu3N8NIBpBwcawIAUWUoYSzQeBUiYNqr86t45BfDHg== X-Received: by 2002:a05:600c:c8c:b0:49d:1d7e:4085 with SMTP id 5b1f17b1804b1-49d1d7e4131mr67217785e9.22.1788938189965; Wed, 09 Sep 2026 00:16:29 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:14f1:e0b5:e1a0:a97c? ([2a01:e0a:106d:1080:14f1:e0b5:e1a0:a97c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d057f4778sm349470395e9.8.2026.09.09.00.16.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 00:16:29 -0700 (PDT) Message-ID: <987c56f5-7828-44b7-ae6b-eb79b15b64ab@linaro.org> Date: Wed, 9 Sep 2026 09:16:28 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2] interconnect: qcom: implement get_bw with rpmh_read To: Maulik Shah , Georgi Djakov Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260908-topic-sm8x50-icc-read-rpmh-v2-1-b6f1c4205450@linaro.org> <9303e64b-00e2-4b8a-b92f-b96c0a3a5546@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <9303e64b-00e2-4b8a-b92f-b96c0a3a5546@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/8/26 16:39, Maulik Shah wrote: > > On 08-09-2026 13:39, Neil Armstrong wrote: >> Since we can actually read back the APPS rpmh interconnect >> BCM votes we can actually implement the get_bw() callback >> and provide a coherent average and peak bandwidth at probe time. >> >> The benefits of that are: >> - keep disabled BCMs disabled >> - avoid voting unused BCMs to INT_MAX >> >> If the interconnects are correctly described for a platform, >> all the required BCMs would be voted to the maximum bandwidth >> until sync_state is reached. >> >> Since we only get the BCM vote, we need to redistribute >> the vote values to the associated nodes. The initial BCM >> votes are read back at probe time in order to be ready when >> the get_bw() is called when a node is added. >> >> Tested-by: Georgi Djakov #db845c >> Signed-off-by: Neil Armstrong >> --- >> Changes in v2: >> - Added tested-by >> - Rebased on v7.3-rc1 now the rpmh_read() is merged >> - Link to v1: https://patch.msgid.link/20251106-topic-sm8x50-icc-read-rpmh-v1-1-d03a2e5ca5f7@linaro.org >> --- >> drivers/interconnect/qcom/bcm-voter.c | 36 +++++++++++++++++++++ >> drivers/interconnect/qcom/bcm-voter.h | 1 + >> drivers/interconnect/qcom/icc-rpmh.c | 60 ++++++++++++++++++++++++++++++++++- >> 3 files changed, 96 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/interconnect/qcom/bcm-voter.c b/drivers/interconnect/qcom/bcm-voter.c >> index a2d437a05a11..9014bf20adad 100644 >> --- a/drivers/interconnect/qcom/bcm-voter.c >> +++ b/drivers/interconnect/qcom/bcm-voter.c >> @@ -261,6 +261,42 @@ void qcom_icc_bcm_voter_add(struct bcm_voter *voter, struct qcom_icc_bcm *bcm) >> } >> EXPORT_SYMBOL_GPL(qcom_icc_bcm_voter_add); >> >> +/** >> + * qcom_icc_bcm_get_bw - get current bcm vote >> + * @voter: voter used to query bcm >> + * @bcm: bcm to get current vote from >> + */ >> +void qcom_icc_bcm_get_bw(struct bcm_voter *voter, >> + struct qcom_icc_bcm *bcm) >> +{ >> + struct tcs_cmd cmd = { .addr = bcm->addr }; >> + int ret, i; >> + u64 x, y; >> + >> + mutex_lock(&voter->lock); >> + >> + rpmh_invalidate(voter->dev); > > Don't see why rpmh_invalidate() is needed before a read request. You're right, will drop. Thanks, Neil > > Thanks, > Maulik > >> + >> + ret = rpmh_read(voter->dev, &cmd); >> + if (ret) { >> + pr_err("Error sending AMC RPMH requests (%d)\n", ret); >> + goto out; >> + } >> + >>