Linux Power Management development
 help / color / mirror / Atom feed
From: Mark Salyzyn <salyzyn@android.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	linux-rtc@vger.kernel.org, andy.shevchenko@gmail.com,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Mark Salyzyn <salyzyn@google.com>,
	Thierry Strudel <tstrudel@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Josh Triplett <josh@joshtriplett.org>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v3 1/4] time: rtc-lib: Add rtc_show_time(const char *prefix_msg)
Date: Wed, 19 Jul 2017 07:52:03 -0700	[thread overview]
Message-ID: <99742846-b47b-4ee5-c971-e26e8a5f935b@android.com> (raw)
In-Reply-To: <CALAqxLWK+_vnG_bpp4dPguNDTt1=JG6GANJm6b=V8gF1UGi1VQ@mail.gmail.com>

On 07/18/2017 05:00 PM, John Stultz wrote:
> On Tue, Jul 18, 2017 at 3:15 PM, Mark Salyzyn <salyzyn@android.com> wrote:
>> Go directly to the rtc for persistent wall clock time and print.
> So, first,  the above doesn't seem accurate to me. You're using
> getnstimeofday64() which doesn't touch the RTC.

I admit I got that backwards. I copied and pasted a line, that was 
supposed to read "We can not go" ... The point was that persistent or 
RTC clock is _not_ always available,
so we have to print suspend times when the timeofday clock is available 
at the points before suspend, and after suspend is complete.

The "Suspended for" message (in ms, we want us at least) albeit helpful, 
is performed at the bottom, and can only be reported if there is a 
persistent clock available. On most Android devices, it is not available.

I will post update, a better description in the primary patch, dropping 
the intro, printing in <epoch>.<ns> format. I asked in another thread if 
it would be OK to preserve the Legacy of RTC time format printing with 
another CONFIG parameter since we have 5 years of tooling that depends 
on that format.

-- Mark

      reply	other threads:[~2017-07-19 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 22:15 [PATCH v3 1/4] time: rtc-lib: Add rtc_show_time(const char *prefix_msg) Mark Salyzyn
2017-07-18 22:36 ` Thomas Gleixner
2017-07-19  0:00 ` John Stultz
2017-07-19 14:52   ` Mark Salyzyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99742846-b47b-4ee5-c971-e26e8a5f935b@android.com \
    --to=salyzyn@android.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=josh@joshtriplett.org \
    --cc=keescook@chromium.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=salyzyn@google.com \
    --cc=tglx@linutronix.de \
    --cc=tstrudel@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox