From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D9913D25D for ; Tue, 28 May 2024 08:43:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716885783; cv=none; b=qWkAlD8k8sGkSNZGDQKF7FfevK9E8Q9W4Q03E+xh51aZYaH7ANphpKVa45uFb/HwCimeGje4m6/nWCkmOpKyWgsyvZeOHSQemZJgFYd2d6JK3C4wNQR2jnfVdAzLY6JVepydVDG6L/YItveFqcN0XscY8SCaJQvJV32HtDy5UQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716885783; c=relaxed/simple; bh=Y6f9O1rB7bAdaik8Ya5stBAwGWAwYs7mHE+WNyPAEOo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fLh5mLsTGXJQgfSWIU42nzpGaSzBwilJtVbKkEwYKeI/d7zucb/tAh5GOCBqZuCyIUVZSRjvbvHxHpZnXURqkqCHzUssrAfZdSaapa336oKJuOboV8CKJ+Y9jpmiGHwfEid9UccBNTMxxKgCVEy2PSTox2VDEcfWYr9jZov63I0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Sa/sbfRd; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Sa/sbfRd" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a6265d47c61so56665766b.0 for ; Tue, 28 May 2024 01:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716885780; x=1717490580; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BDOzOVJxnG+3KEM1LGz7y97uf9duOTHpiqETF8V1CyI=; b=Sa/sbfRdKnz8/QMS+xeYM3nSHA4bJisg2W0l25IlBxTxty4NiXGvKntownbMHodJzp tITa4FnuRTwj/iW57gW2YpY1FtzaZsh2cZBy3u7j9+1DoH0do0vzwd5zeh28ty/BYNd1 wq7I7CvDy/HpeR5LSdeCPZF1OIwueGV55tCuYXt76fGjPc5a3kVlIr7C48gVI67C3K+W oVsUUdRPpTdKUw1u9NXqw5pPv3JoMavC98Sr0y8XLJpcaNUDcB5XhJeDBu0b1aCHl5Pc 7smTUTEtiJbRY9fdWSEjbWUT2ob75jgy8fKva8xkFqI7/zUnZ+S/SJV3q/jTt3CVKkuX F+vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716885780; x=1717490580; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BDOzOVJxnG+3KEM1LGz7y97uf9duOTHpiqETF8V1CyI=; b=IGkgHkCfVWWcKByIPN1RlXZm1jF1teGWAsAJrO6LhizHhnj0308S/t/SIhSTQn8lKs QUEDR683vCBWtgu/nZlTHBGM70HDhfvrxWAN/vk8hTop9MY5p9wVbcerGN4FyUaCXhNH +KjoLEgebfWOfPNt4dIllNy7HWsiquAb4nxXcGwRyUhNqnU7Zj1FOvh6O2Ud6ONhgGjN tw79jL0x5p18kzpRwLeAEwumUFvXkrpzlpqMr3/0SrBucfDqL1rPZ8HyPv2m+JDZba/i 0MPJ+6PLghIMxuOYWzApCvSu22+0DgNkI9avekBT7mLELSp/ePbDk+uD35eT/4txphfi O37w== X-Forwarded-Encrypted: i=1; AJvYcCXakpu9CEsr6PQpyZrcnKSYtfNwDXYkGxw1Mb6GfhI31okGIktpGF1eLVo/5mg4PUjsyY6pHTAv4ryAnVCyw7CeGKlAm97zprc= X-Gm-Message-State: AOJu0YweEG0/F09Z4kwGa008QL71D2xx3JD+ZWGHohUgHPTfD+XCpxiG dzoYSGEIX9LSBfQBSHcB/7+W8ASBLe2RluK4Nrb7YfgC3zcIme+XDs1CZPsILouJKTQdJrhIyug cZo4= X-Google-Smtp-Source: AGHT+IFnwFpVgBPbSYYelUXVLbDbkXbUh2jkTNCogIsjRLaryTZNhcVpgseQGExAcVHtIzwZZr7icw== X-Received: by 2002:a17:906:69d0:b0:a59:9c4d:da3c with SMTP id a640c23a62f3a-a62643ec91cmr716821266b.40.1716885780045; Tue, 28 May 2024 01:43:00 -0700 (PDT) Received: from ?IPV6:2001:a61:139b:bf01:e8eb:4d8f:8770:df82? ([2001:a61:139b:bf01:e8eb:4d8f:8770:df82]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626c8170cbsm585860666b.20.2024.05.28.01.42.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 May 2024 01:42:59 -0700 (PDT) Message-ID: <9a0073a0-d598-4c1a-bb32-328d0a279152@suse.com> Date: Tue, 28 May 2024 10:42:58 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] power: supply: lenovo_yoga_c630_battery: add Lenovo C630 driver To: Dmitry Baryshkov , Oliver Neukum Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Heikki Krogerus , Greg Kroah-Hartman , Konrad Dybcio , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, Nikita Travkin References: <20240527-yoga-ec-driver-v3-0-327a9851dad5@linaro.org> <20240527-yoga-ec-driver-v3-4-327a9851dad5@linaro.org> Content-Language: en-US From: Oliver Neukum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28.05.24 01:15, Dmitry Baryshkov wrote: > On Mon, May 27, 2024 at 02:26:36PM +0200, Oliver Neukum wrote: >> On 27.05.24 12:03, Dmitry Baryshkov wrote: Hi, >>> +struct yoga_c630_psy { >>> + struct yoga_c630_ec *ec; >>> + struct device *dev; >>> + struct device_node *of_node; >>> + struct notifier_block nb; >>> + struct mutex lock; >>> + >>> + struct power_supply *adp_psy; >>> + struct power_supply *bat_psy; >>> + >>> + unsigned long last_status_update; >>> + >>> + bool adapter_online; >>> + >>> + bool unit_mA; >>> + >>> + unsigned int scale; >> >> why do you store unit_mA and scale? This looks redundant and like a source >> of confusion to me. > > Here we just followed the AML code in ACPI tables. The unit_mA is a > returned from the_BIX method, the 'scale' is used internally in the DSDT. > If you think that it's better, I can change all '* scale * 1000' to > 'if unit_mA then foo = bar * 10000 else foo = bar * 1000'. I think that would indeed be better. Implementation details of the DSDT should not dictate data structures in a kernel driver. Regards Oliver