From: Bastian Stender <bst@pengutronix.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Eduardo Valentin <edubezval@gmail.com>,
kernel@pengutronix.de, Zhang Rui <rui.zhang@intel.com>,
shawnguo@kernel.org
Subject: Re: [PATCH] cpufreq: imx6q: add CPU as cooling device
Date: Wed, 15 Nov 2017 10:09:06 +0100 [thread overview]
Message-ID: <9b2c7392-683c-c005-7f5c-0e56dba38074@pengutronix.de> (raw)
In-Reply-To: <20171115090623.GJ3257@vireshk-i7>
On 11/15/2017 10:06 AM, Viresh Kumar wrote:
> On 15-11-17, 10:04, Bastian Stender wrote:
>> Yes, I looked how drivers/cpufreq/mediatek-cpufreq.c handles the cooling
>> device. So dev_pm_opp_free_cpufreq_table is obviously not needed, but why do
>> we need no cpufreq_cooling_unregister call here?
>
> My comment was only for the last line, i.e. dev_pm_opp_free_cpufreq_table(). Of
> course we need to use cpufreq_cooling_unregister() as you pointed out.
Alright.
Regards,
Bastian
--
Pengutronix e.K.
Industrial Linux Solutions
http://www.pengutronix.de/
Peiner Str. 6-8, 31137 Hildesheim, Germany
Amtsgericht Hildesheim, HRA 2686
prev parent reply other threads:[~2017-11-15 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 13:51 [PATCH] cpufreq: imx6q: add CPU as cooling device Bastian Stender
2017-11-15 4:59 ` Viresh Kumar
2017-11-15 9:04 ` Bastian Stender
2017-11-15 9:06 ` Viresh Kumar
2017-11-15 9:09 ` Bastian Stender [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b2c7392-683c-c005-7f5c-0e56dba38074@pengutronix.de \
--to=bst@pengutronix.de \
--cc=edubezval@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).