From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 27CBB24EF8E; Tue, 11 Mar 2025 10:53:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741690390; cv=none; b=MTPASQFGkQPuKCsPraQZDZB/f0Hwc9A9n/ku5BLCQHc/kLyfzYXkA7EDXPFzuBFmC9PUrUtj1wjQte2NHJpVjXoj0oMGrgW6Slv2oC7TTFAFv4OJk8q6OHij2ojhuyS1HMclNTei0FJYnSnEkG8HasV5lSs46JjHZVT2D8ZoPNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741690390; c=relaxed/simple; bh=RUjAfsKxlpnDn5k+IQNu6N7Ia574OxtzAeRXK9rEGak=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y96QaL+h8wts4kC2aNP/hug5WC76zLP7XyXA3BsrDsmOu6K5XuEHO6Pwr7RHRAsVfsbCsHawU4+yJYHpDlEQSkJ3iAm06gH2cWW2vBL2cbp/nfzzzCV2CIT4E1Hj7Exwp8cWKT3Zxsk7YHUJMxf/WP46kYLTqevUFku3ElgsZfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D4061762; Tue, 11 Mar 2025 03:53:19 -0700 (PDT) Received: from [10.57.67.14] (unknown [10.57.67.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B2F743F673; Tue, 11 Mar 2025 03:53:04 -0700 (PDT) Message-ID: <9b44d0ff-b28f-4d79-ad7b-b452db1db87a@arm.com> Date: Tue, 11 Mar 2025 10:53:02 +0000 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 3/3] arm64: dts: renesas: r9a09g047: Add thermal hotplug trip point To: John Madieu , geert+renesas@glider.be, niklas.soderlund+renesas@ragnatech.se, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org Cc: magnus.damm@gmail.com, claudiu.beznea.uj@bp.renesas.com, devicetree@vger.kernel.org, john.madieu@gmail.com, rui.zhang@intel.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, linux-pm@vger.kernel.org References: <20250309121324.29633-1-john.madieu.xa@bp.renesas.com> <20250309121324.29633-4-john.madieu.xa@bp.renesas.com> Content-Language: en-US From: Christian Loehle In-Reply-To: <20250309121324.29633-4-john.madieu.xa@bp.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/9/25 12:13, John Madieu wrote: > Add CPU hotplug trip point to shutdown CPU1 and CPU2 when exceeding 110°C. > > Signed-off-by: John Madieu > --- > arch/arm64/boot/dts/renesas/r9a09g047.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi > index 93b57d7ad7b9..06bd394582e2 100644 > --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi > @@ -533,6 +533,13 @@ map0 { > <&cpu2 0 3>, <&cpu3 0 3>; > contribution = <1024>; > }; > + > + map1 { > + trip = <&trip_emergency>; > + cooling-device = <&cpu1 0 1>, <&cpu2 0 1>; > + contribution = <1024>; > + }; > + > }; > > trips { > @@ -542,6 +549,12 @@ target: trip-point { > type = "passive"; > }; > > + trip_emergency: emergency { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "plug"; > + }; > + > sensor_crit: sensor-crit { > temperature = <120000>; > hysteresis = <1000>; Are there no other cooling methods? How does it compare to idle inject? Furthermore, couldn't the offlining of some CPUs lead to the rest being operated at much higher OPPs therefore the overall power increase, too? (Without having looked at if this is a possibility for this particular SoC.) Some numbers would be helpful IMO.